From: Eric Blake <eblake@redhat.com>
To: Kamil Rytarowski <n54@gmx.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, marcandre.lureau@gmail.com,
armbru@redhat.com, f4bug@amsat.org
Subject: Re: [Qemu-devel] [PATCH] ivshmem-server: ivshmem-client: Build when eventfd() is available
Date: Tue, 30 May 2017 07:53:10 -0500 [thread overview]
Message-ID: <58d04e43-1caa-f623-44fe-749dd351fad9@redhat.com> (raw)
In-Reply-To: <20170530062022.5841-1-n54@gmx.com>
[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]
On 05/30/2017 01:20 AM, Kamil Rytarowski wrote:
> Currently ivshmem requires eventfd() which is Linux specific.
> Do not and build it unconditionally on every Linux/BSD/Solaris.
>
> This patch indirectly fixes build failure on NetBSD, where these tools
> additionally require -lrt for shm_open(3). In future there should be
> added support for NetBSD and the linking addressed appropriately.
Is this a v2 patch? If so, it's best to repost it as a new top-level
thread rather than buried in reply to your v1 patch. Also, be sure to
include v2 in the subject line ('git send-email -v2' works wonders for
that).
>
> Signed-off-by: Kamil Rytarowski <n54@gmx.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> ---
It also helps in a v2 submission to list here, after the --- separator,
how it differs from v1.
More submission hints at http://wiki.qemu.org/Contribute/SubmitAPatch
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-05-30 12:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-13 0:46 [Qemu-devel] [PATCH] ivshmem-server: Detect and use if there is required -lrt linking Kamil Rytarowski
2017-05-13 21:09 ` Philippe Mathieu-Daudé
2017-05-17 7:28 ` Markus Armbruster
2017-05-20 23:05 ` Kamil Rytarowski
2017-05-22 6:28 ` Markus Armbruster
2017-05-22 16:46 ` Kamil Rytarowski
2017-05-23 5:37 ` Markus Armbruster
2017-05-23 14:33 ` Kamil Rytarowski
2017-05-23 15:07 ` Markus Armbruster
2017-05-23 15:08 ` Kamil Rytarowski
2017-05-26 5:40 ` [Qemu-devel] [PATCH] ivshmem-server: ivshmem-clean: Install only when eventfd() is available Kamil Rytarowski
2017-05-26 6:31 ` Marc-André Lureau
2017-05-29 8:57 ` Markus Armbruster
2017-05-30 6:20 ` [Qemu-devel] [PATCH] ivshmem-server: ivshmem-client: Build " Kamil Rytarowski
2017-05-30 12:53 ` Eric Blake [this message]
2017-05-30 13:11 ` Kamil Rytarowski
2017-05-30 14:05 ` Eric Blake
2017-05-31 11:11 ` Markus Armbruster
2017-05-31 11:20 ` Kamil Rytarowski
2017-05-31 13:53 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58d04e43-1caa-f623-44fe-749dd351fad9@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=f4bug@amsat.org \
--cc=marcandre.lureau@gmail.com \
--cc=n54@gmx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).