qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Sergio Lopez <slp@redhat.com>, qemu-devel@nongnu.org
Cc: berrange@redhat.com, ehabkost@redhat.com, mst@redhat.com,
	groug@kaod.org, marcandre.lureau@gmail.com, kraxel@redhat.com,
	pbonzini@redhat.com, imammedo@redhat.com, sgarzare@redhat.com,
	lersek@redhat.com, rth@twiddle.net
Subject: Re: [PATCH v11 14/15] hw/i386: Introduce the microvm machine type
Date: Wed, 30 Oct 2019 10:25:53 +0100	[thread overview]
Message-ID: <58f50ece-5fc2-dcad-f367-455d5f58e184@redhat.com> (raw)
In-Reply-To: <20191018105315.27511-15-slp@redhat.com>

Hi Sergio, Paolo,

On 10/18/19 12:53 PM, Sergio Lopez wrote:
> microvm is a machine type inspired by Firecracker and constructed
> after its machine model.
> 
> It's a minimalist machine type without PCI nor ACPI support, designed
> for short-lived guests. microvm also establishes a baseline for
> benchmarking and optimizing both QEMU and guest operating systems,
> since it is optimized for both boot time and footprint.
> 
> Signed-off-by: Sergio Lopez <slp@redhat.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>   default-configs/i386-softmmu.mak |   1 +
>   include/hw/i386/microvm.h        |  71 ++++
>   hw/i386/microvm.c                | 572 +++++++++++++++++++++++++++++++
>   hw/i386/Kconfig                  |  10 +
>   hw/i386/Makefile.objs            |   1 +
>   5 files changed, 655 insertions(+)
>   create mode 100644 include/hw/i386/microvm.h
>   create mode 100644 hw/i386/microvm.c
> 
> diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak
> index 4229900f57..4cc64dafa2 100644
> --- a/default-configs/i386-softmmu.mak
> +++ b/default-configs/i386-softmmu.mak
> @@ -28,3 +28,4 @@
>   CONFIG_ISAPC=y
>   CONFIG_I440FX=y
>   CONFIG_Q35=y
> +CONFIG_MICROVM=y

Do we want to maintain a 32-bit microvm?

IIUC the main interest in 64-bit.

Can we restrict it with this change?

-- >8 --
diff --git a/default-configs/i386-softmmu.mak 
b/default-configs/i386-softmmu.mak
index 4cc64dafa2..4229900f57 100644
--- a/default-configs/i386-softmmu.mak
+++ b/default-configs/i386-softmmu.mak
@@ -28,4 +28,3 @@
  CONFIG_ISAPC=y
  CONFIG_I440FX=y
  CONFIG_Q35=y
-CONFIG_MICROVM=y
diff --git a/default-configs/x86_64-softmmu.mak 
b/default-configs/x86_64-softmmu.mak
index 64b2ee2960..ef2affe664 100644
--- a/default-configs/x86_64-softmmu.mak
+++ b/default-configs/x86_64-softmmu.mak
@@ -1,3 +1,4 @@
  # Default configuration for x86_64-softmmu

  include i386-softmmu.mak
+CONFIG_MICROVM=y
---

Thanks,

Phil.


  reply	other threads:[~2019-10-30  9:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18 10:53 [PATCH v11 00/15] Introduce the microvm machine type Sergio Lopez
2019-10-18 10:53 ` [PATCH v11 01/15] hw/virtio: Factorize virtio-mmio headers Sergio Lopez
2019-10-18 10:53 ` [PATCH v11 02/15] hw/i386/pc: rename functions shared with non-PC machines Sergio Lopez
2019-10-18 10:53 ` [PATCH v11 03/15] hw/i386/pc: fix code style issues on functions that will be moved out Sergio Lopez
2019-10-18 10:53 ` [PATCH v11 04/15] hw/i386/pc: replace use of strtol with qemu_strtoui in x86_load_linux() Sergio Lopez
2019-10-18 10:53 ` [PATCH v11 05/15] hw/i386/pc: avoid an assignment in if condition " Sergio Lopez
2019-10-18 10:53 ` [PATCH v11 06/15] hw/i386/pc: remove commented out code from x86_load_linux() Sergio Lopez
2019-10-18 10:53 ` [PATCH v11 07/15] hw/i386/pc: move shared x86 functions to x86.c and export them Sergio Lopez
2019-10-18 10:53 ` [PATCH v11 08/15] hw/i386: split PCMachineState deriving X86MachineState from it Sergio Lopez
2019-10-18 10:53 ` [PATCH v11 09/15] hw/i386: make x86.c independent from PCMachineState Sergio Lopez
2019-10-18 10:53 ` [PATCH v11 10/15] fw_cfg: add "modify" functions for all types Sergio Lopez
2019-10-18 10:53 ` [PATCH v11 11/15] hw/intc/apic: reject pic ints if isa_pic == NULL Sergio Lopez
2019-10-18 10:53 ` [PATCH v11 12/15] roms: add microvm-bios (qboot) as binary and git submodule Sergio Lopez
2019-10-18 10:53 ` [PATCH v11 13/15] docs/microvm.rst: document the new microvm machine type Sergio Lopez
2019-10-18 10:53 ` [PATCH v11 14/15] hw/i386: Introduce the " Sergio Lopez
2019-10-30  9:25   ` Philippe Mathieu-Daudé [this message]
2019-10-30 14:18     ` Paolo Bonzini
2019-10-18 10:53 ` [PATCH v11 15/15] MAINTAINERS: add microvm related files Sergio Lopez
2019-11-27 15:41 ` [PATCH v11 00/15] Introduce the microvm machine type Markus Armbruster
2019-12-02 13:01   ` Sergio Lopez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58f50ece-5fc2-dcad-f367-455d5f58e184@redhat.com \
    --to=philmd@redhat.com \
    --cc=berrange@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=groug@kaod.org \
    --cc=imammedo@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lersek@redhat.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=sgarzare@redhat.com \
    --cc=slp@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).