Re: [PATCH v5 1/5] parallels: Incorrect data end calculation in parallels_open()

[Hanna Czenczek <hreitz@redhat.com>]

On 29.05.23 17:14, Alexander Ivanov wrote:
> The BDRVParallelsState structure contains data_end field that is measured
> in sectors. In parallels_open() initially this field is set by data_off
> field from parallels image header.
>
> According to the parallels format documentation, data_off field contains
> an offset, in sectors, from the start of the file to the start of the
> data area. For "WithoutFreeSpace" images: if data_off is zero, the offset
> is calculated as the end of the BAT table plus some padding to ensure
> sector size alignment.
>
> The parallels_open() function has code for handling zero value in
> data_off, but in the result data_end contains the offset in bytes.
>
> Replace the alignment to sector size by division by sector size and fix
> the comparision with s->header_size.
>
> Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
> Reviewed-by: Denis V. Lunev <den@openvz.org>
> ---
>   block/parallels.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Hanna Czenczek <hreitz@redhat.com>