From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Thomas Huth <thuth@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Michael Roth" <michael.roth@amd.com>,
"Konstantin Kostiuk" <kkostiuk@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [PATCH] meson.build: Remove the logic to link C code with the C++ linker
Date: Thu, 6 Jul 2023 10:50:52 +0200 [thread overview]
Message-ID: <590f7428-4f46-0d6f-b616-f77e509013b6@linaro.org> (raw)
In-Reply-To: <20230706064736.178962-1-thuth@redhat.com>
On 6/7/23 08:47, Thomas Huth wrote:
> We are not mixing C++ with C code anymore, the only remaining
> C++ code in qga/vss-win32/ is used for a plain C++ executable.
> Thus we can remove the hacks for linking C code with the C++ linker
> now to simplify meson.build a little bit, and also to avoid that
> some C++ code sneaks in by accident again.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> meson.build | 24 ++++++------------------
> scripts/main.c | 1 -
> qga/meson.build | 2 +-
> 3 files changed, 7 insertions(+), 20 deletions(-)
> delete mode 100644 scripts/main.c
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-07-06 8:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 6:47 [PATCH] meson.build: Remove the logic to link C code with the C++ linker Thomas Huth
2023-07-06 8:35 ` Paolo Bonzini
2023-07-06 8:50 ` Philippe Mathieu-Daudé [this message]
2023-07-06 9:03 ` Konstantin Kostiuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=590f7428-4f46-0d6f-b616-f77e509013b6@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=kkostiuk@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).