Re: [PATCH v4 01/18] linux-user: Introduce imgsrc_read, imgsrc_read_alloc

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 16/8/23 20:03, Richard Henderson wrote:
> Introduced and initialized, but not yet really used.
> These will tidy the current tests vs BPRM_BUF_SIZE.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   linux-user/loader.h    | 61 +++++++++++++++++++++++-----
>   linux-user/linuxload.c | 90 ++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 142 insertions(+), 9 deletions(-)


> +/**
> + * imgsrc_read: Read from ImageSource
> + * @dst: destination for read
> + * @offset: offset within file for read
> + * @len: size of the read
> + * @img: ImageSource to read from
> + * @errp: Error details.
> + *
> + * Read into @dst, using the cache when possible.
> + */
> +bool imgsrc_read(void *dst, off_t offset, size_t len,
> +                 const ImageSource *img, Error **errp);
> +
> +/**
> + * imgsrc_read_alloc: Read from ImageSource
> + * @offset: offset within file for read
> + * @size: size of the read
> + * @img: ImageSource to read from
> + * @errp: Error details.
> + *
> + * Read into newly allocated memory, using the cache when possible.
> + */
> +void *imgsrc_read_alloc(off_t offset, size_t len,
> +                        const ImageSource *img, Error **errp);
> +
> +/**
> + * imgsrc_mmap: Map from ImageSource
> + *
> + * If @src has a file descriptor, pass on to target_mmap.  Otherwise,
> + * this is "mapping" from a host buffer, which resolves to memcpy.
> + * Therefore, flags must be MAP_PRIVATE | MAP_FIXED; the argument is
> + * retained for clarity.
> + */
> +abi_long imgsrc_mmap(abi_ulong start, abi_ulong len, int prot,
> +                     int flags, const ImageSource *src, abi_ulong offset);

Nitpicking, having imgsrc_mmap() in another patch would ease review
(in case you ever respin). Otherwise:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>