Re: [Qemu-devel] [PATCH 05/12] migration: Move colo.h to migration/

[Hailiang Zhang <zhang.zhanghailiang@huawei.com>]

On 2017/5/15 19:04, Juan Quintela wrote:
> "Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> D> * Juan Quintela (quintela@redhat.com) wrote:
>>> There are functions only used by migration code.
>> That's only mostly true; see the current 'integrate colo frame with
>> block replication and net compare' series (posted 22nd April).
>> That adds colo_handle_shutdown to this header and calls it from vl.c
>> ( https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg03901.html )
>> where should that go?
> Dropped.
>
> It compiled, but who knows O:-)
>
>> There's also a net/colo.h as well, so using the
>>    #include "colo.h" in migration is correct but that's
>> really scary when there are two files of the same name.

Ha, I'd like to suggest it be renamed as colo-proxy.h (colo-net.h ? ) for net/colo.h,
which is saner,  hmm, together with colo.c, colo-proxy.c ? colo-net.c ? Or any other proper name ?
( I didn't notice that until it went into upstream.  O:-) )

Cc:  Zhang Chen <zhangchen.fnst@cn.fujitsu.com>

> Yeap, it is scary ...
>
>
>