From: Wei Wang <wei.w.wang@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: jasowang@redhat.com, stefanha@gmail.com,
marcandre.lureau@gmail.com, "pbonzini"@redhat.com,
jan.scheurich@ericsson.com, virtio-dev@lists.oasis-open.org,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [virtio-dev] Re: [PATCH RFC] virtio-net: enable configurable tx queue size
Date: Mon, 22 May 2017 19:52:12 +0800 [thread overview]
Message-ID: <5922D0EC.6060405@intel.com> (raw)
In-Reply-To: <20170519233750-mutt-send-email-mst@kernel.org>
On 05/20/2017 04:42 AM, Michael S. Tsirkin wrote:
> On Fri, May 19, 2017 at 10:32:19AM +0800, Wei Wang wrote:
>> This patch enables the virtio-net tx queue size to be configurable
>> between 256 (the default queue size) and 1024 by the user. The queue
>> size specified by the user should be power of 2.
>>
>> Setting the tx queue size to be 1024 requires the guest driver to
>> support the VIRTIO_NET_F_MAX_CHAIN_SIZE feature.
> This should be a generic ring feature, not one specific to virtio net.
OK. How about making two more changes below:
1) make the default tx queue size = 1024 (instead of 256).
We can reduce the size (to 256) if the MAX_CHAIN_SIZE feature
is not supported by the guest.
In this way, people who apply the QEMU patch can directly use the
largest queue size(1024) without adding the booting command line.
2) The vhost backend does not use writev, so I think when the vhost
backed is used, using 1024 queue size should not depend on the
MAX_CHAIN_SIZE feature.
Best,
Wei
next prev parent reply other threads:[~2017-05-22 11:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 2:32 [Qemu-devel] [PATCH RFC] virtio-net: enable configurable tx queue size Wei Wang
2017-05-19 20:42 ` Michael S. Tsirkin
2017-05-22 11:52 ` Wei Wang [this message]
2017-05-23 2:04 ` [Qemu-devel] [virtio-dev] " Jason Wang
2017-05-23 5:15 ` Wei Wang
2017-05-23 6:24 ` Jason Wang
2017-05-23 10:36 ` Wei Wang
2017-05-24 3:19 ` Jason Wang
2017-05-24 8:18 ` Wei Wang
2017-05-25 7:49 ` Jason Wang
2017-05-25 11:50 ` Wei Wang
2017-05-25 12:13 ` [Qemu-devel] [virtio-dev] " Jason Wang
2017-05-25 18:04 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5922D0EC.6060405@intel.com \
--to=wei.w.wang@intel.com \
--cc=jan.scheurich@ericsson.com \
--cc=jasowang@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).