From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Thomas Huth <huth@tuxfamily.org>,
Joaquin de Andres <me@xcancerberox.com.ar>,
Michael Rolnik <mrolnik@gmail.com>,
Sarah Harris <S.E.Harris@kent.ac.uk>
Subject: Re: [PATCH v2 3/4] target/avr/disas: Fix store instructions display order
Date: Tue, 7 Jul 2020 09:35:48 -0700 [thread overview]
Message-ID: <5925dc7a-38dc-4e3f-a43e-70dfaf873c13@linaro.org> (raw)
In-Reply-To: <20200707070021.10031-4-f4bug@amsat.org>
On 7/7/20 12:00 AM, Philippe Mathieu-Daudé wrote:
> While LOAD instructions use the target register as first
> argument, STORE instructions use it as second argument:
>
> LD Rd, X // Rd <- (X)
>
> ST Y, Rd // (Y) <- Rr
>
> Reported-by: Joaquin de Andres <me@xcancerberox.com.ar>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/avr/disas.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-07-07 16:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 7:00 [PATCH v2 0/4] target/avr: Few fixes Philippe Mathieu-Daudé
2020-07-07 7:00 ` [PATCH v2 1/4] target/avr/cpu: Drop tlb_flush() in avr_cpu_reset() Philippe Mathieu-Daudé
2020-07-07 8:21 ` Thomas Huth
2020-07-07 16:34 ` Richard Henderson
2020-07-07 7:00 ` [PATCH v2 2/4] target/avr/cpu: Fix $PC displayed address Philippe Mathieu-Daudé
2020-07-07 8:22 ` Thomas Huth
2020-07-07 16:34 ` Richard Henderson
2020-07-07 7:00 ` [PATCH v2 3/4] target/avr/disas: Fix store instructions display order Philippe Mathieu-Daudé
2020-07-07 16:35 ` Richard Henderson [this message]
2020-07-07 7:00 ` [RFC PATCH v2 4/4] target/avr/translate: Fix SBRC/SBRS instructions Philippe Mathieu-Daudé
2020-07-07 16:34 ` Richard Henderson
2020-07-07 16:58 ` Philippe Mathieu-Daudé
2020-07-10 18:25 ` Richard Henderson
2020-07-07 17:58 ` [PATCH v2 0/4] target/avr: Few fixes Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5925dc7a-38dc-4e3f-a43e-70dfaf873c13@linaro.org \
--to=richard.henderson@linaro.org \
--cc=S.E.Harris@kent.ac.uk \
--cc=f4bug@amsat.org \
--cc=huth@tuxfamily.org \
--cc=me@xcancerberox.com.ar \
--cc=mrolnik@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).