From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/5] fw_cfg: Drop newline in @file description
Date: Tue, 16 Oct 2018 00:31:10 +0200 [thread overview]
Message-ID: <592b19a1-cdc4-634c-40f1-d1d29e4a33c7@redhat.com> (raw)
In-Reply-To: <20181015172817.19796-6-mreitz@redhat.com>
On 15/10/2018 19:28, Max Reitz wrote:
> There is no good reason why there should be a newline in this
> description, so remove it.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> vl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vl.c b/vl.c
> index f9ed053eab..19f8cc67ff 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -529,7 +529,7 @@ static QemuOptsList qemu_fw_cfg_opts = {
> }, {
> .name = "file",
> .type = QEMU_OPT_STRING,
> - .help = "Sets the name of the file from which\n"
> + .help = "Sets the name of the file from which "
> "the fw_cfg blob will be loaded",
> }, {
> .name = "string",
>
prev parent reply other threads:[~2018-10-15 22:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 17:28 [Qemu-devel] [PATCH 0/5] Various option help readability improvement suggestions Max Reitz
2018-10-15 17:28 ` [Qemu-devel] [PATCH 1/5] option: Make option help nicer to read Max Reitz
2018-10-16 6:46 ` Marc-André Lureau
2018-10-19 9:59 ` Max Reitz
2018-10-16 12:12 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2018-10-19 10:00 ` Max Reitz
2018-10-17 6:50 ` [Qemu-devel] " Markus Armbruster
2018-10-19 10:00 ` Max Reitz
2018-10-15 17:28 ` [Qemu-devel] [PATCH 2/5] chardev: Indent list of chardevs Max Reitz
2018-10-15 17:28 ` [Qemu-devel] [PATCH 3/5] qdev-monitor: Make device options help nicer Max Reitz
2018-10-15 17:28 ` [Qemu-devel] [PATCH 4/5] object: Make option help nicer to read Max Reitz
2018-10-15 17:28 ` [Qemu-devel] [PATCH 5/5] fw_cfg: Drop newline in @file description Max Reitz
2018-10-15 22:31 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=592b19a1-cdc4-634c-40f1-d1d29e4a33c7@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).