From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/8] microblaze: fix leak of fdevice tree blob
Date: Tue, 1 Oct 2019 16:01:59 +0200 [thread overview]
Message-ID: <5948b4bd-e7cb-bcdb-1666-8b0edb7a2be0@redhat.com> (raw)
In-Reply-To: <1569936988-635-3-git-send-email-pbonzini@redhat.com>
On 10/1/19 3:36 PM, Paolo Bonzini wrote:
> The device tree blob returned by load_device_tree is malloced.
> Free it before returning.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/microblaze/boot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/microblaze/boot.c b/hw/microblaze/boot.c
> index bade4d2..d1d7dfb 100644
> --- a/hw/microblaze/boot.c
> +++ b/hw/microblaze/boot.c
> @@ -100,6 +100,7 @@ static int microblaze_load_dtb(hwaddr addr,
> }
>
> cpu_physical_memory_write(addr, fdt, fdt_size);
> + g_free(fdt);
> return fdt_size;
> }
>
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2019-10-01 14:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 13:36 [PATCH ci-fix 0/8] fix various memory leaks (but not all) Paolo Bonzini
2019-10-01 13:36 ` [PATCH 1/8] ide: fix leak from qemu_allocate_irqs Paolo Bonzini
2019-10-01 14:25 ` Thomas Huth
2019-10-01 15:28 ` Eric Blake
2019-10-01 15:58 ` Peter Maydell
2019-10-01 16:52 ` Paolo Bonzini
2019-10-01 13:36 ` [PATCH 2/8] microblaze: fix leak of fdevice tree blob Paolo Bonzini
2019-10-01 14:01 ` Philippe Mathieu-Daudé [this message]
2019-10-01 13:36 ` [PATCH 3/8] mcf5208: fix leak from qemu_allocate_irqs Paolo Bonzini
2019-10-01 14:28 ` Thomas Huth
2019-10-01 13:36 ` [PATCH 4/8] hppa: fix leak from g_strdup_printf Paolo Bonzini
2019-10-01 13:59 ` Philippe Mathieu-Daudé
2019-10-01 13:36 ` [PATCH 5/8] mips: fix memory leaks in board initialization Paolo Bonzini
2019-10-01 14:34 ` Thomas Huth
2019-10-01 13:36 ` [PATCH 6/8] cris: do not leak struct cris_disasm_data Paolo Bonzini
2019-10-01 13:36 ` [PATCH 7/8] lm32: do not leak memory on object_new/object_unref Paolo Bonzini
2019-10-01 14:04 ` Philippe Mathieu-Daudé
2019-10-01 13:36 ` [PATCH 8/8] docker: test-debug: disable LeakSanitizer Paolo Bonzini
2019-10-01 13:59 ` Philippe Mathieu-Daudé
2019-10-01 16:53 ` Paolo Bonzini
2019-10-01 19:28 ` [PATCH ci-fix 0/8] fix various memory leaks (but not all) no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5948b4bd-e7cb-bcdb-1666-8b0edb7a2be0@redhat.com \
--to=philmd@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).