Re: [PATCH] linux-user/sh4/termbits: Silence warning about TIOCSER_TEMT double definition

[Thomas Huth <thuth@redhat.com>]

On 31/03/2022 19.31, Richard Henderson wrote:
> On 3/31/22 10:22, Laurent Vivier wrote:
>> Le 30/03/2022 à 15:43, Thomas Huth a écrit :
>>> Seen while compiling on Alpine:
>>>
>>>   In file included from ../linux-user/strace.c:17:
>>>   In file included from ../linux-user/qemu.h:11:
>>>   In file included from ../linux-user/syscall_defs.h:1247:
>>>   ../linux-user/sh4/termbits.h:276:10: warning: 'TIOCSER_TEMT' macro 
>>> redefined
>>>    [-Wmacro-redefined]
>>>   # define TIOCSER_TEMT    0x01   /* Transmitter physically empty */
>>>            ^
>>>   /usr/include/sys/ioctl.h:50:9: note: previous definition is here
>>>   #define TIOCSER_TEMT 1
>>>           ^
>>>   1 warning generated.
>>>
>>> Add the TARGET_ prefix here, too, like we do it on the other architectures.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>>   linux-user/sh4/termbits.h | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Thomas,
>>
>> do you think it can wait 7.1?
> 
> It fixes a build problem, so I'd suggest putting it in for 7.0.

It's just a warning, so unless the user compiles with --enable-werror, it 
should be harmless. Anyway, I see that Laurent already picked it up (thanks!).

  Thomas