From: Paolo Bonzini <pbonzini@redhat.com>
To: David Hildenbrand <dahi@daveh.de>
Cc: Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour
Date: Thu, 13 Oct 2016 03:49:20 -0400 (EDT) [thread overview]
Message-ID: <595255889.2791024.1476344960142.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20161012183815.GA24542@localhost>
----- Original Message -----
> From: "David Hildenbrand" <dahi@daveh.de>
> To: "Claudio Imbrenda" <imbrenda@linux.vnet.ibm.com>
> Cc: "David Hildenbrand" <dahi@daveh.de>, "Paolo Bonzini" <pbonzini@redhat.com>, qemu-devel@nongnu.org
> Sent: Wednesday, October 12, 2016 8:38:15 PM
> Subject: Re: [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour
>
> On Wed, Oct 12, 2016 at 03:55:18PM +0200, Claudio Imbrenda wrote:
> > On 12/10/16 15:15, David Hildenbrand wrote:
> > >>> + for (cx = 0; ccpus && ccpus[cx]; cx++) {
> > >>> + cpu_single_step(cpu, 0);
> > >
> > > This looks suspicious
> >
> > why? we set all cpus to single step, since that is the default, and then
> > we clear the single-step property from all CPUs that should be restarted
> > in normal mode, then we restart all CPUs. Those in single-step will
> > indeed only perform one single step, the others will run freely (at
> > least until the first single-step CPU stops again).
>
> actually I was more concerned about calling it on "cpu" in a loop.
And we all missed that it should have been ccpus[cx], not cpu. :)
Paolo
prev parent reply other threads:[~2016-10-13 7:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 11:50 [Qemu-devel] [PATCH v1 0/2] Qemu: gdbstub: fix vCont and single-step Claudio Imbrenda
2016-10-10 11:50 ` [Qemu-devel] [PATCH v1 1/2] gdbstub: Fix single-step Claudio Imbrenda
2016-10-10 12:51 ` Christian Borntraeger
2016-10-10 14:36 ` Paolo Bonzini
2016-10-10 15:46 ` [Qemu-devel] [PATCH] kvm-all: don't use stale dbg_data->cpu Alex Bennée
2016-10-10 16:39 ` Paolo Bonzini
2016-10-10 17:18 ` Christian Borntraeger
2016-10-11 11:48 ` Claudio Imbrenda
2016-10-10 11:50 ` [Qemu-devel] [PATCH v1 2/2] gdbstub: Fix vCont behaviour Claudio Imbrenda
2016-10-11 8:18 ` Paolo Bonzini
2016-10-12 13:15 ` David Hildenbrand
2016-10-12 13:55 ` Claudio Imbrenda
2016-10-12 16:48 ` Paolo Bonzini
2016-10-12 18:38 ` David Hildenbrand
2016-10-13 7:49 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=595255889.2791024.1476344960142.JavaMail.zimbra@redhat.com \
--to=pbonzini@redhat.com \
--cc=dahi@daveh.de \
--cc=imbrenda@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).