From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPxUV-0003jV-VN for qemu-devel@nongnu.org; Thu, 22 Nov 2018 17:30:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPxUR-000225-Rm for qemu-devel@nongnu.org; Thu, 22 Nov 2018 17:30:31 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:37582) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gPxUR-00021v-Jv for qemu-devel@nongnu.org; Thu, 22 Nov 2018 17:30:27 -0500 Received: by mail-wr1-f68.google.com with SMTP id j10so10583334wru.4 for ; Thu, 22 Nov 2018 14:30:27 -0800 (PST) References: <20181122172653.3413-1-peter.maydell@linaro.org> <20181122172653.3413-3-peter.maydell@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <595264a1-d9f1-010b-e2db-2b391ad6d20f@redhat.com> Date: Thu, 22 Nov 2018 23:30:25 +0100 MIME-Version: 1.0 In-Reply-To: <20181122172653.3413-3-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 for-4.0 2/3] monitor: Use address_space_read() to read memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Markus Armbruster , "Dr. David Alan Gilbert" , patches@linaro.org On 22/11/18 18:26, Peter Maydell wrote: > Currently monitor.c reads physical memory using > cpu_physical_memory_read(). This effectively hard-codes > assuming that all CPUs have the same view of physical > memory. Switch to address_space_read() instead, which > lets us use the AddressSpace for the CPU we're > reading memory for (falling back to address_space_memory > if there is no CPU, as happens with the "none" board). > As a bonus, this allows us to detect failures to read memory. > > Signed-off-by: Peter Maydell > Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé > --- > monitor.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/monitor.c b/monitor.c > index d39390c2f2f..b0e8f2c490a 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -1604,7 +1604,13 @@ static void memory_dump(Monitor *mon, int count, int format, int wsize, > if (l > line_size) > l = line_size; > if (is_physical) { > - cpu_physical_memory_read(addr, buf, l); > + AddressSpace *as = cs ? cs->as : &address_space_memory; > + MemTxResult r = address_space_read(as, addr, > + MEMTXATTRS_UNSPECIFIED, buf, l); > + if (r != MEMTX_OK) { > + monitor_printf(mon, " Cannot access memory\n"); > + break; > + } > } else { > if (cpu_memory_rw_debug(cs, addr, buf, l, 0) < 0) { > monitor_printf(mon, " Cannot access memory\n"); >