From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQV5y-0003G8-Qq for qemu-devel@nongnu.org; Mon, 09 Jan 2017 03:14:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cQV5v-0001U4-Ms for qemu-devel@nongnu.org; Mon, 09 Jan 2017 03:14:22 -0500 Received: from 8.mo178.mail-out.ovh.net ([46.105.74.227]:55245) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cQV5v-0001TH-Fx for qemu-devel@nongnu.org; Mon, 09 Jan 2017 03:14:19 -0500 Received: from player714.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo178.mail-out.ovh.net (Postfix) with ESMTP id 8E403C51C for ; Mon, 9 Jan 2017 09:14:15 +0100 (CET) References: <20170108083854.5006-1-mar.krzeminski@gmail.com> <20170108083854.5006-4-mar.krzeminski@gmail.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <598b60e9-15a9-b4ee-b46d-aa8d03f9cef6@kaod.org> Date: Mon, 9 Jan 2017 09:14:08 +0100 MIME-Version: 1.0 In-Reply-To: <20170108083854.5006-4-mar.krzeminski@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 3/3] block: m25p80: Improve 1GiB Micron flash definition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcin Krzeminski , qemu-devel@nongnu.org, edgar.iglesias@xilinx.com Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org On 01/08/2017 09:38 AM, Marcin Krzeminski wrote: > n25q00 and mt25q01 devices share the same JEDEC ID. The difference > between those two devices is number of dies and one bit in extended > JEDEC bytes. This commit adds proper entry for both devices by > introduction the number of dies and and new 25q00 entries. >=20 > Signed-off-by: Marcin Krzeminski Reviewed-by: C=E9dric Le Goater Thanks, C. > --- > hw/block/m25p80.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c > index a9b025b..fb5cef3 100644 > --- a/hw/block/m25p80.c > +++ b/hw/block/m25p80.c > @@ -242,8 +242,10 @@ static const FlashPartInfo known_devices[] =3D { > { INFO("n25q128", 0x20ba18, 0, 64 << 10, 256, 0) }, > { INFO("n25q256a", 0x20ba19, 0, 64 << 10, 512, ER_4K) }, > { INFO("n25q512a", 0x20ba20, 0, 64 << 10, 1024, ER_4K) }, > - { INFO("mt25ql01g", 0x20ba21, 0, 64 << 10, 2048, ER_4K) }, > - { INFO("mt25qu01g", 0x20bb21, 0, 64 << 10, 2048, ER_4K) }, > + { INFO_STACKED("n25q00", 0x20ba21, 0x1000, 64 << 10, 2048, ER_4= K, 4) }, > + { INFO_STACKED("n25q00a", 0x20bb21, 0x1000, 64 << 10, 2048, ER_4= K, 4) }, > + { INFO_STACKED("mt25ql01g", 0x20ba21, 0x1040, 64 << 10, 2048, ER_4= K, 2) }, > + { INFO_STACKED("mt25qu01g", 0x20bb21, 0x1040, 64 << 10, 2048, ER_4= K, 2) }, > =20 > /* Spansion -- single (large) sector size only, at least > * for the chips listed here (without boot sectors). >=20