From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 437ABC10DCE for ; Fri, 6 Mar 2020 15:24:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 104642073B for ; Fri, 6 Mar 2020 15:24:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (4096-bit key) header.d=crudebyte.com header.i=@crudebyte.com header.b="RDKu6J53" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 104642073B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=crudebyte.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAEq3-00053f-Ao for qemu-devel@archiver.kernel.org; Fri, 06 Mar 2020 10:24:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48995) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAEpG-0004ZM-Dp for qemu-devel@nongnu.org; Fri, 06 Mar 2020 10:23:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jAEpF-0008CI-9g for qemu-devel@nongnu.org; Fri, 06 Mar 2020 10:23:46 -0500 Received: from kylie.crudebyte.com ([5.189.157.229]:45699) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jAEpE-00088j-Ow for qemu-devel@nongnu.org; Fri, 06 Mar 2020 10:23:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=kylie; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Content-ID:Content-Description; bh=1XUk7rQ+1fEVdVUuAVOTHvk4V6WXfz2h9CTcsCjE/3w=; b=RDKu6J537f3xfAhD0hWWYkiFLG MU9L43y0Qun4A0vuyESjSSRFaePGUBuNAX9fECyoKOhIZC2WShmSh8/uNpn8uJY90LDYn0TJ/UzP5 TWTc2NBygkfAVc5Yj6+boCFCy3+BvP0xsQAFehrTM4GuxQ4OAG7hyTMmudHCU1jow7w2wgSxhymEV LfBfGSbg6FLDc2a8Iv+I/ZtJKSb8GEy87XVp0XUwFYFg6tiUoaa3cENP25ZnTSKtC5wBxV/okfM/e GU5YvL92u0Qvx8Ce+4Ap9KYDkiGM6ruzVBdVbQ1yKblKpJz/hVfWsorGnjQNHLQkplppwJbCOyVci aFJfCzWTwDS/6ZJpmCS4D9mazkuggFpwURJd6zFJD0Cht40mQbWjMECGQIYwgmMLwQIhwpukKs5fW KcOTeGU3983deElNZZpWOeEW4EGK4vhjne3P28zD/JOJHkR1nKfFS8Cfi2kgebW0mkWMKCIl/zeLR iXThESbzZOhCMuaDGryXEiN7n9dkuTrEotLEFN32Ku1PTQO5Z2eKQEpJftt2BNjuZeBUtKbnbCYqM gInxYGlz19ncx3gcT/PbzfsN7yJKdegRUooaIMIruZ+FZsSxbmekjXICGf/VCKCO4BzYorZFAneWH eVM+fFiEFVChlWfxM2A5OWX+PzsAWLNldDizYIUTQ=; From: Christian Schoenebeck To: Greg Kurz Cc: qemu-devel@nongnu.org, Paolo Bonzini , =?ISO-8859-1?Q?St=E9phane?= Graber Subject: Re: [PATCH] 9p/proxy: Fix export_flags Date: Fri, 06 Mar 2020 16:23:41 +0100 Message-ID: <5999542.GsCrKgYN1H@silver> In-Reply-To: <158349633705.1237488.8895481990204796135.stgit@bahia.lan> References: <158349633705.1237488.8895481990204796135.stgit@bahia.lan> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 5.189.157.229 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Freitag, 6. M=E4rz 2020 13:05:37 CET Greg Kurz wrote: > The common fsdev options are set by qemu_fsdev_add() before it calls > the backend specific option parsing code. In the case of "proxy" this > means "writeout" or "readonly" were simply ignored. This has been > broken from the beginning. >=20 > Signed-off-by: Greg Kurz Reviewed-by: Christian Schoenebeck > --- > hw/9pfs/9p-proxy.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/9pfs/9p-proxy.c b/hw/9pfs/9p-proxy.c > index 8136e1342d78..6f598a0f111c 100644 > --- a/hw/9pfs/9p-proxy.c > +++ b/hw/9pfs/9p-proxy.c > @@ -1139,10 +1139,10 @@ static int proxy_parse_opts(QemuOpts *opts, > FsDriverEntry *fs, Error **errp) } > if (socket) { > fs->path =3D g_strdup(socket); > - fs->export_flags =3D V9FS_PROXY_SOCK_NAME; > + fs->export_flags |=3D V9FS_PROXY_SOCK_NAME; > } else { > fs->path =3D g_strdup(sock_fd); > - fs->export_flags =3D V9FS_PROXY_SOCK_FD; > + fs->export_flags |=3D V9FS_PROXY_SOCK_FD; > } > return 0; > }