From: Jason Wang <jasowang@redhat.com>
To: "Zhang, Chen" <chen.zhang@intel.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-dev <qemu-devel@nongnu.org>,
Li Zhijian <lizhijian@cn.fujitsu.com>,
Zhang Chen <zhangckid@gmail.com>
Subject: Re: [Qemu-devel] [PATCH V5] net/colo-compare.c: Fix memory leak and code style issue.
Date: Tue, 23 Jul 2019 11:23:56 +0800 [thread overview]
Message-ID: <599f9e75-3d85-c1e7-fe6b-34c95d9d240c@redhat.com> (raw)
In-Reply-To: <9CFF81C0F6B98A43A459C9EDAD400D78061D67D3@shsmsx102.ccr.corp.intel.com>
On 2019/7/23 上午2:38, Zhang, Chen wrote:
>
>
>> -----Original Message-----
>> From: Peter Maydell [mailto:peter.maydell@linaro.org]
>> Sent: Tuesday, July 23, 2019 1:25 AM
>> To: Zhang, Chen <chen.zhang@intel.com>
>> Cc: Li Zhijian <lizhijian@cn.fujitsu.com>; Jason Wang <jasowang@redhat.com>;
>> qemu-dev <qemu-devel@nongnu.org>; Zhang Chen <zhangckid@gmail.com>
>> Subject: Re: [PATCH V5] net/colo-compare.c: Fix memory leak and code style
>> issue.
>>
>> On Mon, 22 Jul 2019 at 18:23, Zhang Chen <chen.zhang@intel.com> wrote:
>>> From: Zhang Chen <chen.zhang@intel.com>
>>>
>>> This patch to fix the origin "char *data" memory leak, code style
>>> issue and add necessary check here.
>>> Reported-by: Coverity (CID 1402785)
>>>
>>> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
>>> ---
>>> net/colo-compare.c | 27 ++++++++++++++++++++-------
>>> 1 file changed, 20 insertions(+), 7 deletions(-)
>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>>
>> Thanks for your patience in sending out all these versions as we worked
>> through the code review process.
> Thank you too~
> Maybe you or Jason can pick up this patch?
>
> Thanks
> Zhang Chen
Applied.
Thanks
>
>> thanks
>> -- PMM
next prev parent reply other threads:[~2019-07-23 3:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 17:18 [Qemu-devel] [PATCH V5] net/colo-compare.c: Fix memory leak and code style issue Zhang Chen
2019-07-22 17:24 ` Peter Maydell
2019-07-22 18:38 ` Zhang, Chen
2019-07-23 3:23 ` Jason Wang [this message]
2019-07-25 9:27 ` Peter Maydell
2019-07-25 9:31 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=599f9e75-3d85-c1e7-fe6b-34c95d9d240c@redhat.com \
--to=jasowang@redhat.com \
--cc=chen.zhang@intel.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).