From: "WangJie (Captain)" <wangjie88@huawei.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: berto@igalia.com, stefanha@redhat.com, eblake@redhat.com,
qemu-devel@nongnu.org
Subject: [Qemu-devel] question:a question about throttle and hot-unplug
Date: Thu, 14 Sep 2017 17:41:40 +0800 [thread overview]
Message-ID: <59BA4ED4.6070108@huawei.com> (raw)
Hi, Kevin
the patch you commited: https://github.com/qemu/qemu/commit/7ca7f0f6db1fedd28d490795d778cf23979a2aa7#diff-ea36ba0f79150cc299732696a069caba
remove blk_io_limits_disable from blk_remove_bs
Then, if a disk which configured qos hot-unplug from VM, the backend of the disk reminds in throttle group.
So when I hot-unplug and hot-plug a disk, and use the same throttle group name, will lead to qemu crash.
and Eric committed a path as fallow fixed the bug on qemu-kvm 2.9.0-rc4:
https://github.com/qemu/qemu/commit/1606e4cf8a976513ecac70ad6642a7ec45744cf5#diff-7cb66df56045598b75a219eebc27efb6
Is what I said as below correct? I just want to make sure it. Thank you :)
next reply other threads:[~2017-09-14 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 9:41 WangJie (Captain) [this message]
2017-09-14 11:34 ` [Qemu-devel] question:a question about throttle and hot-unplug Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59BA4ED4.6070108@huawei.com \
--to=wangjie88@huawei.com \
--cc=berto@igalia.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).