* [Qemu-devel] question：a question about throttle and hot-unplug
@ 2017-09-14 9:41 WangJie (Captain)
2017-09-14 11:34 ` Alberto Garcia
0 siblings, 1 reply; 2+ messages in thread
From: WangJie (Captain) @ 2017-09-14 9:41 UTC (permalink / raw)
To: Kevin Wolf; +Cc: berto, stefanha, eblake, qemu-devel
Hi, Kevin
the patch you commited: https://github.com/qemu/qemu/commit/7ca7f0f6db1fedd28d490795d778cf23979a2aa7#diff-ea36ba0f79150cc299732696a069caba
remove blk_io_limits_disable from blk_remove_bs
Then, if a disk which configured qos hot-unplug from VM, the backend of the disk reminds in throttle group.
So when I hot-unplug and hot-plug a disk, and use the same throttle group name, will lead to qemu crash.
and Eric committed a path as fallow fixed the bug on qemu-kvm 2.9.0-rc4:
https://github.com/qemu/qemu/commit/1606e4cf8a976513ecac70ad6642a7ec45744cf5#diff-7cb66df56045598b75a219eebc27efb6
Is what I said as below correct? I just want to make sure it. Thank you :）
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] question：a question about throttle and hot-unplug
2017-09-14 9:41 [Qemu-devel] question：a question about throttle and hot-unplug WangJie (Captain)
@ 2017-09-14 11:34 ` Alberto Garcia
0 siblings, 0 replies; 2+ messages in thread
From: Alberto Garcia @ 2017-09-14 11:34 UTC (permalink / raw)
To: WangJie (Captain), Kevin Wolf; +Cc: stefanha, eblake, qemu-devel
On Thu 14 Sep 2017 11:41:40 AM CEST, WangJie (Captain) wrote:
> the patch you commited: https://github.com/qemu/qemu/commit/7ca7f0f6db1fedd28d490795d778cf23979a2aa7#diff-ea36ba0f79150cc299732696a069caba
>
> remove blk_io_limits_disable from blk_remove_bs
>
> Then, if a disk which configured qos hot-unplug from VM, the backend
> of the disk reminds in throttle group.
>
> So when I hot-unplug and hot-plug a disk, and use the same throttle
> group name, will lead to qemu crash.
>
> and Eric committed a path as fallow fixed the bug on qemu-kvm 2.9.0-rc4:
> https://github.com/qemu/qemu/commit/1606e4cf8a976513ecac70ad6642a7ec45744cf5#diff-7cb66df56045598b75a219eebc27efb6
>
> Is what I said as below correct?
That sounds correct to me. Here's the original discussion for reference:
https://lists.gnu.org/archive/html/qemu-block/2017-04/msg00019.html
Berto
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-14 11:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-14 9:41 [Qemu-devel] question：a question about throttle and hot-unplug WangJie (Captain)
2017-09-14 11:34 ` Alberto Garcia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).