From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] tcg: Remove TCG_TARGET_HAS_{br, set}cond2 from riscv and loongarch64
Date: Sun, 16 Feb 2025 20:04:39 +0100 [thread overview]
Message-ID: <59a4c4f6-341b-45b5-82af-472e2930889a@linaro.org> (raw)
In-Reply-To: <20250216024709.2624325-3-richard.henderson@linaro.org>
On 16/2/25 03:47, Richard Henderson wrote:
> These defines never should have been added as they were
> never used. Only 32-bit hosts may have these opcodes and
> they have them unconditionally.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/loongarch64/tcg-target-has.h | 2 --
> tcg/riscv/tcg-target-has.h | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/tcg/loongarch64/tcg-target-has.h b/tcg/loongarch64/tcg-target-has.h
> index ac88522eef..188b00799f 100644
> --- a/tcg/loongarch64/tcg-target-has.h
> +++ b/tcg/loongarch64/tcg-target-has.h
> @@ -37,8 +37,6 @@
> #define TCG_TARGET_HAS_clz_i32 1
> #define TCG_TARGET_HAS_ctz_i32 1
> #define TCG_TARGET_HAS_ctpop_i32 0
> -#define TCG_TARGET_HAS_brcond2 0
> -#define TCG_TARGET_HAS_setcond2 0
> #define TCG_TARGET_HAS_qemu_st8_i32 0
Fixes: 6cb14e4de29 ("tcg/loongarch64: Add the tcg-target.h file")
Missed in 0a16d036154 ("tcg/loongarch64: Extract TCG_TARGET_HAS_foo defs
to 'tcg-target-has.h'")
> diff --git a/tcg/riscv/tcg-target-has.h b/tcg/riscv/tcg-target-has.h
> index f35f9b31f5..98081084f2 100644
> --- a/tcg/riscv/tcg-target-has.h
> +++ b/tcg/riscv/tcg-target-has.h
> @@ -37,8 +37,6 @@
> #define TCG_TARGET_HAS_clz_i32 (cpuinfo & CPUINFO_ZBB)
> #define TCG_TARGET_HAS_ctz_i32 (cpuinfo & CPUINFO_ZBB)
> #define TCG_TARGET_HAS_ctpop_i32 (cpuinfo & CPUINFO_ZBB)
> -#define TCG_TARGET_HAS_brcond2 1
> -#define TCG_TARGET_HAS_setcond2 1
> #define TCG_TARGET_HAS_qemu_st8_i32 0
Fixes: fb1f70f3685 ("tcg/riscv: Add the tcg-target.h file")
Missed in 0242532b45d ("tcg/riscv: Extract TCG_TARGET_HAS_foo defs to
'tcg-target-has.h'")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-02-16 19:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-16 2:47 [PATCH 0/2] tcg: minor cleanups Richard Henderson
2025-02-16 2:47 ` [PATCH 1/2] tcg/i386: Use tcg_{high, unsigned}_cond in tcg_out_brcond2 Richard Henderson
2025-02-16 18:44 ` Philippe Mathieu-Daudé
2025-02-16 2:47 ` [PATCH 2/2] tcg: Remove TCG_TARGET_HAS_{br, set}cond2 from riscv and loongarch64 Richard Henderson
2025-02-16 19:04 ` Philippe Mathieu-Daudé [this message]
2025-02-17 0:42 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59a4c4f6-341b-45b5-82af-472e2930889a@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).