From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57DDAC433F5 for ; Tue, 24 May 2022 13:31:34 +0000 (UTC) Received: from localhost ([::1]:50834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ntUdJ-000241-6L for qemu-devel@archiver.kernel.org; Tue, 24 May 2022 09:31:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntUad-0000o9-AA for qemu-devel@nongnu.org; Tue, 24 May 2022 09:28:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:47530) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntUaa-00062j-4G for qemu-devel@nongnu.org; Tue, 24 May 2022 09:28:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653398922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UfqCS6y03BXWklgjB6BwscOqoyG8gMvC27NB1OserB0=; b=Y4L2kEzBNcxvVeY8UKwk3OOHJTle52a/o0cppp08vovs/YMwMEjLMwBmYXvBaA3aMFDE7S WqWPDqR1LfmdH/MN/qVy/WB10kha0bIPUcR477EoBl75hOyKR7zTIhgWGi7LMsQuog7CIr NIvX8s+C+ZezUC21+Tfxpntk1g20cP4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-658-k_OEXNbeNUCzck-XaTu9Zw-1; Tue, 24 May 2022 09:28:41 -0400 X-MC-Unique: k_OEXNbeNUCzck-XaTu9Zw-1 Received: by mail-wr1-f70.google.com with SMTP id p10-20020adfaa0a000000b0020c4829af5fso4832013wrd.16 for ; Tue, 24 May 2022 06:28:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UfqCS6y03BXWklgjB6BwscOqoyG8gMvC27NB1OserB0=; b=lTuiLD9YTRJrSkdxwormk07bDLnYSt/t/kTU2oq9dzJFQJJC07dW74z/+iiVV9TLMs GLpukc4fGxZfMZ7mIeyXie9zKgnB5nj+BR3fPW4/WeAaq2PZvhExHS3hyF1+TkZACVIu xFJZEHYdkUCGkAU72JLBwNoJvNOgM3fRjix+oVxqxCjWg0ce8YSwB/+t0WPWQi+rzmGu 7pfflu+skawm8qIrooSsvzgKJKdeMI20drfacIqv/xCLyVT1HlQXHjH0Bjz2epr/t2bs ZXTOr4iquZcXzdm4wy2iEnvopAvaS+gEgYSaJvU23puLyz/4hfHgMgsJG7qBGYAZ/Rr2 Wzug== X-Gm-Message-State: AOAM532suSxZKNbE/Mx4nDu9OvKQoSmfZLf0dA1dwAL9wTj1DhOVY3cP /MnNcrLyTtIhAZJRu1tgYvSjEp2Q1XZpz5c30kUUYjKkfVp9k7S5eufFI1yPGyBNS5/NV9cgaM5 R3J5A/lt/MbOE0oQ= X-Received: by 2002:adf:fb47:0:b0:20c:de00:a96a with SMTP id c7-20020adffb47000000b0020cde00a96amr23514957wrs.376.1653398920183; Tue, 24 May 2022 06:28:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycIOwxCkgW2XyWBQvaAN39SFX81bld+z529oI1wX8A0mc5PrHvFiRNV/cjvpcKMd0hYjad6g== X-Received: by 2002:adf:fb47:0:b0:20c:de00:a96a with SMTP id c7-20020adffb47000000b0020cde00a96amr23514943wrs.376.1653398919957; Tue, 24 May 2022 06:28:39 -0700 (PDT) Received: from [10.33.192.183] (nat-pool-str-t.redhat.com. [149.14.88.106]) by smtp.gmail.com with ESMTPSA id k21-20020a7bc315000000b003942a244edfsm2328796wmj.36.2022.05.24.06.28.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 May 2022 06:28:38 -0700 (PDT) Message-ID: <59b8bdee-ef2f-83b4-fbc7-4283cb964c33@redhat.com> Date: Tue, 24 May 2022 15:28:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PULL 2/3] qga-win32: Add support for NVME but type Content-Language: en-US To: Konstantin Kostiuk , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= Cc: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Stefan Weil , Richard Henderson , QEMU , Peter Maydell References: <20220523194111.827805-1-kkostiuk@redhat.com> <20220523194111.827805-3-kkostiuk@redhat.com> <541f46cf-fc45-f7bb-e121-2aad216e11d5@linaro.org> <449f117b-32c9-e066-55dd-1208313bce3f@redhat.com> From: Thomas Huth In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 24/05/2022 15.17, Konstantin Kostiuk wrote: > > > On Tue, May 24, 2022 at 4:13 PM Thomas Huth > wrote: > > On 24/05/2022 15.00, Konstantin Kostiuk wrote: > > > > > > > > > > On Tue, May 24, 2022 at 1:24 PM Thomas Huth > > >> wrote: > > > >     On 24/05/2022 12.14, Marc-André Lureau wrote: > >      > Hi > >      > > >      > On Tue, May 24, 2022 at 12:02 PM Konstantin Kostiuk > >      > >> wrote: > >      >> > >      >> Hi Richard and Marc-André > >      >> > >      >> I looked into the compilation problem and have 2 solutions: > >      >> 1. We can add some conditions to the win2qemu definition and > >      >> skip NVME support when old mingw-headers are used. > >      >> 2. We can bump the version of the Fedora docker image to 36 or 37 > >      >> that is used for cross-compilation tests. > >      >> > >      >> I think the second option is more valuable because we remove > >      >> pregenerated qga-vss.tlb file and now we can check VSS build only > >      >> at Fedora 37. > >      >> > >      >> What do you think? > >      > > >      > I'd try to do both: fix compilation with older headers, and > bump our > >      > CI to f36. I don't know if our windows build environment has > strict > >      > requirements like the unix/distro (build on old-stable for 2y). > > > >     See > https://www.qemu.org/docs/master/about/build-platforms.html#windows > > > >   > : > > > >     "The project supports building QEMU with current versions of the > MinGW > >     toolchain, either hosted on Linux (Debian/Fedora) or via MSYS2 on > Windows." > > > >     Since Fedora 35 is still a supported build host, I think you > should make > >     sure that it works with the MinGW toolchain from that distro, too. > > > > > > Currently, CI uses Fedora 33 which is already EOL. Fedora 35 has updated > > mingw-headers and the current version of code compiles without any > errors. > > So if we want to support only Fedora 35+, we can just bump the CI > docker image. > > Ah, right, I was looking at the wrong file. So yes, in that case, please > simply update the docker image. > > What about Debian (since this is mentioned on the support page, too)? I > think we don't have to worry about Debian 10 anymore, since Debian 10 will > already be EOL once we release QEMU 7.1 ... but what about Debian 11? Do > the > MinGW packages there contain the updated headers, too? > > > As I know we do not test cross-compilation at Debian. Debian does not have > even mingw-glib2. Debian only has the mingw-gcc toolkit. Oh, interesting! Then I wonder why Debian is mentioned there ... seems like it has been added here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=e6e80fcfd6c47823 Daniel, do you remember whether we supported Debian for MinGW cross-compilation in the past? Thomas