From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, mdroth@linux.vnet.ibm.com
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: Early 4.1.1 release for image corruption fixes?
Date: Fri, 25 Oct 2019 16:31:59 +0200 [thread overview]
Message-ID: <59c32499-04b8-87ba-1740-081fe0b2f21c@redhat.com> (raw)
In-Reply-To: <20191025142915.GG7275@localhost.localdomain>
[-- Attachment #1.1: Type: text/plain, Size: 1379 bytes --]
On 25.10.19 16:29, Kevin Wolf wrote:
> Hi,
>
> the QEMU 4.1.0 release has two problems that can easily cause image
> corruption with any qcow2 images (no special configuration needed to
> trigger the bugs):
Three, actually. There’s also b2c6f23f4a9f6d8f1b648705cd46d3713b78d6a2
which fixed 50ba5b2d994853b38fed10e0841b119da0f8b8e5 that was part of
4.1.0, too.
> 1. A locking bug in the qcow2 code. I just sent a pull request that
> includes the fix for this. The important patch there is:
>
> 'qcow2: Fix corruption bug in qcow2_detect_metadata_preallocation()'
>
> 2. A kernel bug in the XFS driver that became visible by new I/O
> patterns the qcow2 implementation started to use in 4.1. Max is
> currently working on a workaround for this.
You most likely won’t see the kernel bug on 4.1.0, because 50ba5b2d99 is
basically the same bug, but in qemu...
(I don’t know if it has the same technical reason, but it causes the
same symptoms.)
Max
> The Planning/4.1 wiki page tells me that a 4.1.1 release is planned for
> end of November, which isn't too far, but I was wondering if want to
> have a stable release even earlier, right after the fixes for both
> problems are in.
>
> Peter, if we haven't made a decision until then, maybe discussing this
> is an agenda item for QEMU Summit, too.
>
> Kevin
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-10-25 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 14:29 Early 4.1.1 release for image corruption fixes? Kevin Wolf
2019-10-25 14:31 ` Max Reitz [this message]
2019-10-25 15:03 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59c32499-04b8-87ba-1740-081fe0b2f21c@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).