From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Thomas Huth" <thuth@redhat.com>,
qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Eric Auger" <eric.auger@redhat.com>
Cc: qemu-arm@nongnu.org, qemu-trivial@nongnu.org, qemu-riscv@nongnu.org
Subject: Re: [PATCH] include/hw: Do not include "hw/registerfields.h" in headers that don't need it
Date: Fri, 10 Feb 2023 13:42:34 +0100 [thread overview]
Message-ID: <59c5bb4a-ece3-0e70-ea22-ae9408809d04@linaro.org> (raw)
In-Reply-To: <20230210112315.1116966-1-thuth@redhat.com>
On 10/2/23 12:23, Thomas Huth wrote:
> Include "hw/registerfields.h" in the .c files instead (if needed).
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> include/hw/arm/smmuv3.h | 1 -
> include/hw/char/ibex_uart.h | 1 -
> include/hw/ssi/ibex_spi_host.h | 1 -
> hw/char/ibex_uart.c | 1 +
> hw/ssi/ibex_spi_host.c | 1 +
> 5 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/include/hw/arm/smmuv3.h b/include/hw/arm/smmuv3.h
> index f1921fdf9e..b6dd087526 100644
> --- a/include/hw/arm/smmuv3.h
> +++ b/include/hw/arm/smmuv3.h
> @@ -20,7 +20,6 @@
> #define HW_ARM_SMMUV3_H
>
> #include "hw/arm/smmu-common.h"
> -#include "hw/registerfields.h"
Never required.
> #define TYPE_SMMUV3_IOMMU_MEMORY_REGION "smmuv3-iommu-memory-region"
> diff --git a/include/hw/char/ibex_uart.h b/include/hw/char/ibex_uart.h
> index a39985516a..9deadf223b 100644
> --- a/include/hw/char/ibex_uart.h
> +++ b/include/hw/char/ibex_uart.h
> @@ -26,7 +26,6 @@
> #define HW_IBEX_UART_H
>
> #include "hw/sysbus.h"
> -#include "hw/registerfields.h"
Missed in bdc36ce649 ("hw/char/ibex_uart: Make the register layout
private").
> #include "chardev/char-fe.h"
> #include "qemu/timer.h"
> #include "qom/object.h"
> diff --git a/include/hw/ssi/ibex_spi_host.h b/include/hw/ssi/ibex_spi_host.h
> index 1f6d077766..8089cc1c31 100644
> --- a/include/hw/ssi/ibex_spi_host.h
> +++ b/include/hw/ssi/ibex_spi_host.h
> @@ -32,7 +32,6 @@
> #include "hw/ssi/ssi.h"
> #include "qemu/fifo8.h"
> #include "qom/object.h"
> -#include "hw/registerfields.h"
Never required.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2023-02-10 12:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 11:23 [PATCH] include/hw: Do not include "hw/registerfields.h" in headers that don't need it Thomas Huth
2023-02-10 12:42 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59c5bb4a-ece3-0e70-ea22-ae9408809d04@linaro.org \
--to=philmd@linaro.org \
--cc=eric.auger@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).