From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Eric Blake <eblake@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH-for-10.2 v2] osdep: Undefine FSCALE definition to fix Solaris builds
Date: Tue, 9 Dec 2025 20:37:11 +0100 [thread overview]
Message-ID: <59d0c2a3-d2c5-481f-96b8-494e6301593c@linaro.org> (raw)
In-Reply-To: <20251203120315.62889-1-philmd@linaro.org>
On 3/12/25 13:03, Philippe Mathieu-Daudé wrote:
> Solaris defines FSCALE in <sys/param.h>:
>
> 301 /*
> 302 * Scale factor for scaled integers used to count
> 303 * %cpu time and load averages.
> 304 */
> 305 #define FSHIFT 8 /* bits to right of fixed binary point */
> 306 #define FSCALE (1<<FSHIFT)
>
> When emulating the SVE FSCALE instruction, we defines the same name
> in decodetree format in target/arm/tcg/sve.decode:
>
> 1129:FSCALE 01100101 .. 00 1001 100 ... ..... ..... @rdn_pg_rm
>
> This leads to a definition clash:
>
> In file included from ../target/arm/tcg/translate-sve.c:21:
> ../target/arm/tcg/translate.h:875:17: error: pasting "trans_" and "(" does not give a valid preprocessing token
> 875 | static bool trans_##NAME(DisasContext *s, arg_##NAME *a) \
> | ^~~~~~
> ../target/arm/tcg/translate-sve.c:4205:5: note: in expansion of macro 'TRANS_FEAT'
> 4205 | TRANS_FEAT(NAME, FEAT, gen_gvec_fpst_arg_zpzz, name##_zpzz_fns[a->esz], a)
> | ^~~~~~~~~~
> ../target/arm/tcg/translate-sve.c:4249:1: note: in expansion of macro 'DO_ZPZZ_FP'
> 4249 | DO_ZPZZ_FP(FSCALE, aa64_sve, sve_fscalbn)
> | ^~~~~~~~~~
> ../target/arm/tcg/translate-sve.c:4249:12: error: expected declaration specifiers or '...' before numeric constant
> 4249 | DO_ZPZZ_FP(FSCALE, aa64_sve, sve_fscalbn)
> | ^~~~~~
> ../target/arm/tcg/translate.h:875:25: note: in definition of macro 'TRANS_FEAT'
> 875 | static bool trans_##NAME(DisasContext *s, arg_##NAME *a) \
> | ^~~~
> ../target/arm/tcg/translate-sve.c:4249:1: note: in expansion of macro 'DO_ZPZZ_FP'
> 4249 | DO_ZPZZ_FP(FSCALE, aa64_sve, sve_fscalbn)
> | ^~~~~~~~~~
> ../target/arm/tcg/translate.h:875:47: error: pasting "arg_" and "(" does not give a valid preprocessing token
> 875 | static bool trans_##NAME(DisasContext *s, arg_##NAME *a) \
> | ^~~~
> ../target/arm/tcg/translate-sve.c:4205:5: note: in expansion of macro 'TRANS_FEAT'
> 4205 | TRANS_FEAT(NAME, FEAT, gen_gvec_fpst_arg_zpzz, name##_zpzz_fns[a->esz], a)
> | ^~~~~~~~~~
> ../target/arm/tcg/translate-sve.c:4249:1: note: in expansion of macro 'DO_ZPZZ_FP'
> 4249 | DO_ZPZZ_FP(FSCALE, aa64_sve, sve_fscalbn)
> | ^~~~~~~~~~
> In file included from ../target/arm/tcg/translate-sve.c:100:
> libqemu-aarch64-softmmu.a.p/decode-sve.c.inc:1227:13: warning: 'trans_FSCALE' used but never defined
> 1227 | static bool trans_FSCALE(DisasContext *ctx, arg_FSCALE *a);
> | ^~~~~~~~~~~~
> ../target/arm/tcg/translate-sve.c:4249:30: warning: 'sve_fscalbn_zpzz_fns' defined but not used [-Wunused-const-variable=]
> 4249 | DO_ZPZZ_FP(FSCALE, aa64_sve, sve_fscalbn)
> | ^~~~~~~~~~~
> ../target/arm/tcg/translate-sve.c:4201:42: note: in definition of macro 'DO_ZPZZ_FP'
> 4201 | static gen_helper_gvec_4_ptr * const name##_zpzz_fns[4] = { \
> | ^~~~
>
> As a kludge, undefine it globally in <qemu/osdep.h>.
>
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/qemu/osdep.h | 6 ++++++
> 1 file changed, 6 insertions(+)
Per IRC:
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
prev parent reply other threads:[~2025-12-09 19:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 12:03 [PATCH-for-10.2 v2] osdep: Undefine FSCALE definition to fix Solaris builds Philippe Mathieu-Daudé
2025-12-09 19:37 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59d0c2a3-d2c5-481f-96b8-494e6301593c@linaro.org \
--to=philmd@linaro.org \
--cc=eblake@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).