From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4130AC28B2E for ; Tue, 11 Mar 2025 04:51:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1trraN-0004N5-Kn; Tue, 11 Mar 2025 00:51:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trra9-0004FE-51; Tue, 11 Mar 2025 00:51:09 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trra7-0004W6-B1; Tue, 11 Mar 2025 00:51:08 -0400 Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52AKFa9K028851; Tue, 11 Mar 2025 04:51:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=JCbXuX /o19da+dS0uxclvRt+JOIe19qWvaEzF/bqVqU=; b=Q0+f3eBox1c5sDQ/vM1LWB UDLbmIWvu1hV0yTINfgn0qRTQ2LcdzLgEVl5rWCgex/maRbBNtzyLWIdcPl46aof fN2jm8i/37M8DVJWWLZve01/xnMHyExbzXQFaJWMCU+uW755DbkNiWmy7WgH3fyM 8kSuW4Bv49y4kiDEXO1YWTS5SzCsbrxjHSrOoq89aQbSvBWIxvDCfhsg2ecZht/w ZCBbVn7FomBPzvTkDu9xfNcZ/nLXUdokQz0EWqEEu6FT2jqWmObTDWPUMf97QXXR ngu3tR2iO1lFN7/tszCQgto0IJTysxNJxfTQ9YAolPVHpYtLG6YylyOZ5fJn47tQ == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45a042v6rj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Mar 2025 04:51:04 +0000 (GMT) Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 52B4p4aO010752; Tue, 11 Mar 2025 04:51:04 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45a042v6rf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Mar 2025 04:51:04 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 52B18t9i023841; Tue, 11 Mar 2025 04:51:03 GMT Received: from smtprelay03.wdc07v.mail.ibm.com ([172.16.1.70]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4590kytde5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Mar 2025 04:51:03 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 52B4p0jL29098634 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Mar 2025 04:51:00 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1D07158063; Tue, 11 Mar 2025 04:51:02 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 910005804B; Tue, 11 Mar 2025 04:50:59 +0000 (GMT) Received: from [9.109.242.165] (unknown [9.109.242.165]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 11 Mar 2025 04:50:59 +0000 (GMT) Message-ID: <59df1008-2127-4ae4-b8e7-72334c58f12e@linux.ibm.com> Date: Tue, 11 Mar 2025 10:20:58 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/7] hw/ppc: Handle stash command in PowerNV SBE To: Aditya Gupta , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Nicholas Piggin , =?UTF-8?B?RnLDqWTDqXJpYyBCYXJyYXQ=?= , Sourabh Jain , Mahesh J Salgaonkar , Hari Bathini References: <20250217071934.86131-1-adityag@linux.ibm.com> <20250217071934.86131-4-adityag@linux.ibm.com> Content-Language: en-US From: Harsh Prateek Bora In-Reply-To: <20250217071934.86131-4-adityag@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: YbX7O5sEnsQdBWaypVWtBRdJMLzcJVBK X-Proofpoint-ORIG-GUID: 1taRBcKS03ykbyHHO4NZkxQRXWc5--1j X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-11_01,2025-03-07_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxlogscore=999 impostorscore=0 clxscore=1015 mlxscore=0 priorityscore=1501 spamscore=0 adultscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2503110028 Received-SPF: pass client-ip=148.163.156.1; envelope-from=harshpb@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/17/25 12:49, Aditya Gupta wrote: > Earlier since the SBE_CMD_STASH_MPIPL_CONFIG command was not handled, so > skiboot used to not get any response from SBE: > > [ 106.350742821,3] SBE: Message timeout [chip id = 0], cmd = d7, subcmd = 7 > [ 106.352067746,3] SBE: Failed to send stash MPIPL config [chip id = 0x0, rc = 254] > > Fix this by handling the command in PowerNV SBE, and sending a response so > skiboot knows SBE has handled the STASH command > > The stashed skiboot base is later used to access the relocated MDST/MDDT > tables when MPIPL is implemented. > > The purpose of stashing relocated base address is explained in following > skiboot commit: > > author Vasant Hegde Fri Jul 12 16:47:51 2019 +0530 > committer Oliver O'Halloran Thu Aug 15 17:53:39 2019 +1000 > > SBE: Send OPAL relocated base address to SBE > > OPAL relocates itself during boot. During memory preserving IPL hostboot needs > to access relocated OPAL base address to get MDST, MDDT tables. Hence send > relocated base address to SBE via 'stash MPIPL config' chip-op. During next > IPL SBE will send stashed data to hostboot... so that hostboot can access > these data. > > Signed-off-by: Aditya Gupta > --- > hw/ppc/pnv_sbe.c | 25 +++++++++++++++++++++++++ > include/hw/ppc/pnv_sbe.h | 3 +++ > 2 files changed, 28 insertions(+) > > diff --git a/hw/ppc/pnv_sbe.c b/hw/ppc/pnv_sbe.c > index a6bf13650f2d..79818177fc36 100644 > --- a/hw/ppc/pnv_sbe.c > +++ b/hw/ppc/pnv_sbe.c > @@ -82,6 +82,8 @@ > #define SBE_CONTROL_REG_S0 PPC_BIT(14) > #define SBE_CONTROL_REG_S1 PPC_BIT(15) > > +static uint64_t mpipl_skiboot_base = 0x30000000 /*default SKIBOOT_BASE*/; > + > static void pnv_sbe_set_host_doorbell(PnvSBE *sbe, uint64_t val) > { > val &= SBE_HOST_RESPONSE_MASK; /* Is this right? What does HW do? */ > @@ -281,6 +283,29 @@ static void do_sbe_msg(PnvSBE *sbe) > timer_del(sbe->timer); > } > break; > + case SBE_CMD_STASH_MPIPL_CONFIG: > + /* key = sbe->mbox[1] */ > + switch (sbe->mbox[1]) { > + case SBE_STASH_KEY_SKIBOOT_BASE: > + mpipl_skiboot_base = sbe->mbox[2]; > + qemu_log_mask(LOG_UNIMP, > + "Stashing skiboot base: 0x%lx\n", mpipl_skiboot_base); > + > + /* > + * Set the response register. > + * > + * Currently setting the same sequence number in > + * response as we got in the request. > + */ > + sbe->mbox[4] = sbe->mbox[0]; /* sequence number */ > + pnv_sbe_set_host_doorbell(sbe, > + sbe->host_doorbell | SBE_HOST_RESPONSE_WAITING); > + > + break; > + default: > + qemu_log_mask(LOG_UNIMP, "SBE Unimplemented command: 0x%x\n", cmd); Unimplemented SBE_CMD_STASH_MPIPL_CONFIG key ? > + } > + break; > default: > qemu_log_mask(LOG_UNIMP, "SBE Unimplemented command: 0x%x\n", cmd); > } > diff --git a/include/hw/ppc/pnv_sbe.h b/include/hw/ppc/pnv_sbe.h > index b6b378ad14c7..f6cbcf990ed9 100644 > --- a/include/hw/ppc/pnv_sbe.h > +++ b/include/hw/ppc/pnv_sbe.h > @@ -53,4 +53,7 @@ struct PnvSBEClass { > const MemoryRegionOps *xscom_mbox_ops; > }; > > +/* Helper to access stashed SKIBOOT_BASE */ > +bool pnv_sbe_mpipl_skiboot_base(void); > + > #endif /* PPC_PNV_SBE_H */