From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwXOu-0003Mc-AR for qemu-devel@nongnu.org; Mon, 25 Sep 2017 13:42:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwXOp-0001bJ-EU for qemu-devel@nongnu.org; Mon, 25 Sep 2017 13:42:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41108) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dwXOp-0001ax-8P for qemu-devel@nongnu.org; Mon, 25 Sep 2017 13:42:31 -0400 References: <1506071794-4373-1-git-send-email-thuth@redhat.com> <20170925135316.74fed6da.cohuck@redhat.com> <20170925133153.GZ3030@localhost.localdomain> <20170925154647.357047b9@nial.brq.redhat.com> <20170925143439.GA3030@localhost.localdomain> From: Thomas Huth Message-ID: <59e890ab-45e4-fe8a-a8de-3c441de19080@redhat.com> Date: Mon, 25 Sep 2017 19:42:13 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] qdev: Mark devices as non-hotpluggable by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Eduardo Habkost , Igor Mammedov , Cornelia Huck , QEMU Developers , Paolo Bonzini , Xiao Guangrong , "Michael S. Tsirkin" , Marcel Apfelbaum , Christian Borntraeger , Gerd Hoffmann , Stefano Stabellini , Anthony Perard , David Hildenbrand , David Gibson , Bharata B Rao , Amit Shah On 25.09.2017 17:26, Peter Maydell wrote: > On 25 September 2017 at 16:19, Thomas Huth wrote: >> Not sure whether this works for the virtio-xxx-device devices, >> though, since they are marked as user_creatable =3D true currently... >=20 > That's deliberate -- for the arm boards with virtio-mmio > the board creates a bunch of virtio-mmio transports and the > virtio-foo-device can be user created to plug into those. Yes, I know ... I'm just wondering whether the virtio-xxx-device devices should be non-user_creatable on the non-ARM targets, since they apparently can't be used with "-device" there...? > If overall trying to do the 'right thing' is tricky here > then perhaps we can start by flipping the default to > not-hotpluggable and marking some devices hotpluggable > that in theory shouldn't be with a comment about why. Yes, if Eduardo's idea to move the test to qmp_device_add() does not work out (I'll try that next), your suggestion is certainly the best thing we can do right now. > Incidentally I think there's still some advantage in the > "created as part of some other device" devices having > to be explicitly marked hotpluggable, because those > devices do still need some specific code in them to > handle it (ie code to release the resources that are > created in the device's realize method). Ok ... by the way, does anybody know more devices like virtio-xxx-device, i.e. devices that are indirectly plugged when adding other devices? Thomas