From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: "Tao Tang" <tangtao1634@phytium.com.cn>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Fabiano Rosas" <farosas@suse.de>,
"Laurent Vivier" <lvivier@redhat.com>,
"Eric Auger" <eric.auger@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
"Chen Baozi" <chenbaozi@phytium.com.cn>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Jean-Philippe Brucker" <jean-philippe@linaro.org>,
"Mostafa Saleh" <smostafa@google.com>,
"CLEMENT MATHIEU--DRIF" <clement.mathieu--drif@eviden.com>
Subject: Re: [RFC RESEND v5 1/4] hw/arm/smmuv3: Extract common definitions to smmuv3-common.h
Date: Thu, 4 Dec 2025 10:19:37 -0800 [thread overview]
Message-ID: <59eb723b-e34f-4a5e-a2c5-2e3242cba8df@linaro.org> (raw)
In-Reply-To: <20251126154547.1300748-2-tangtao1634@phytium.com.cn>
On 11/26/25 7:45 AM, Tao Tang wrote:
> Move register definitions, command enums, and Stream Table Entry (STE) /
> Context Descriptor (CD) structure definitions from the internal header
> hw/arm/smmuv3-internal.h to a new common header
> include/hw/arm/smmuv3-common.h.
>
> This allows other components, such as generic SMMUv3 tests or test devices,
> to utilize these definitions without including the specific SMMUv3 device
> internal state.
>
> In addition, refactor the STE and CD field definitions to consistently use
> the 'hw/registerfields.h' API and introduce corresponding setter macros to
> facilitate structure manipulation.
>
> Signed-off-by: Tao Tang <tangtao1634@phytium.com.cn>
> ---
> hw/arm/smmuv3-internal.h | 255 +-----------------
> include/hw/arm/smmuv3-common.h | 461 +++++++++++++++++++++++++++++++++
> 2 files changed, 462 insertions(+), 254 deletions(-)
> create mode 100644 include/hw/arm/smmuv3-common.h
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
next prev parent reply other threads:[~2025-12-04 18:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 15:45 [RFC RESEND v5 0/4] hw/misc: Introduce a generalized IOMMU test framework Tao Tang
2025-11-26 15:45 ` [RFC RESEND v5 1/4] hw/arm/smmuv3: Extract common definitions to smmuv3-common.h Tao Tang
2025-12-04 18:19 ` Pierrick Bouvier [this message]
2025-11-26 15:45 ` [RFC RESEND v5 2/4] hw/misc: Introduce iommu-testdev for bare-metal IOMMU testing Tao Tang
2025-12-04 18:36 ` Pierrick Bouvier
2025-12-10 18:35 ` Eric Auger
2025-12-11 7:27 ` Tao Tang
2025-11-26 15:45 ` [RFC RESEND v5 3/4] tests/qtest/libqos: Add SMMUv3 helper library Tao Tang
2025-12-04 23:53 ` Pierrick Bouvier
2025-12-05 15:03 ` Tao Tang
2025-12-05 17:19 ` Pierrick Bouvier
2025-12-06 5:27 ` Tao Tang
2025-12-10 18:40 ` Eric Auger
2025-12-11 8:53 ` Tao Tang
2025-12-10 18:43 ` Eric Auger
2025-12-11 9:39 ` Tao Tang
2025-11-26 15:45 ` [RFC RESEND v5 4/4] tests/qtest: Add SMMUv3 bare-metal test using iommu-testdev Tao Tang
2025-12-04 18:42 ` Pierrick Bouvier
2025-12-05 14:19 ` Tao Tang
2025-12-05 17:06 ` Pierrick Bouvier
2025-12-06 4:54 ` Tao Tang
2025-12-10 18:45 ` Eric Auger
2025-12-11 8:06 ` Tao Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59eb723b-e34f-4a5e-a2c5-2e3242cba8df@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=chenbaozi@phytium.com.cn \
--cc=clement.mathieu--drif@eviden.com \
--cc=eric.auger@redhat.com \
--cc=farosas@suse.de \
--cc=jean-philippe@linaro.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=smostafa@google.com \
--cc=tangtao1634@phytium.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).