From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eE9HO-000103-Au for qemu-devel@nongnu.org; Mon, 13 Nov 2017 02:35:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eE9HK-0002HQ-BR for qemu-devel@nongnu.org; Mon, 13 Nov 2017 02:35:38 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2343) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1eE9HJ-0002GR-P3 for qemu-devel@nongnu.org; Mon, 13 Nov 2017 02:35:34 -0500 Message-ID: <5A094ADD.406@huawei.com> Date: Mon, 13 Nov 2017 15:33:49 +0800 From: "Longpeng (Mike)" MIME-Version: 1.0 References: <1509951528-30976-1-git-send-email-longpeng2@huawei.com> <1509951528-30976-2-git-send-email-longpeng2@huawei.com> <20171110170237.GA18834@stefanha-x1.localdomain> In-Reply-To: <20171110170237.GA18834@stefanha-x1.localdomain> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [v21 RESEND 1/2] virtio-crypto: Add virtio crypto device specification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, pasic@linux.vnet.ibm.com, Ola.Liljedahl@arm.com, brian.a.keating@intel.com, wangxinxin.wang@huawei.com, mst@redhat.com, xin.zeng@intel.com, jasowang@redhat.com, luonengjun@huawei.com, agraf@suse.de, john.griffin@intel.com, arei.gonglei@huawei.com, liang.j.ma@intel.com, stefanha@redhat.com, jianjay.zhou@huawei.com, cornelia.huck@de.ibm.com, Varun.Sethi@freescale.com, Jani.Kokkonen@huawei.com, vincent.jardin@6wind.com, denglingli@chinamobile.com, weidong.huang@huawei.com Hi Stefan, On 2017/11/11 1:02, Stefan Hajnoczi wrote: > On Mon, Nov 06, 2017 at 02:58:47PM +0800, Longpeng(Mike) wrote: >> From: Gonglei >> >> The virtio crypto device is a virtual crypto device (ie. hardware >> crypto accelerator card). Currently, the virtio crypto device provides >> the following crypto services: CIPHER, MAC, HASH, and AEAD. >> >> In this patch, CIPHER, MAC, HASH, AEAD services are introduced. >> >> VIRTIO-153 >> >> Signed-off-by: Gonglei >> Signed-off-by: Longpeng(Mike) > > This doesn't build cleanly for me on commit > 2faf9b0666886abc0ca99f6813446a4e2a04f3ca > (https://github.com/oasis-tcs/virtio-spec master): > > $ > $ ./makeall.sh > ! LaTeX Error: Lonely \item--perhaps a missing list environment. > > See the LaTeX manual or LaTeX Companion for explanation. > Type H for immediate help. > ... > > l.384 \item I > f the VIRTIO_CRYPTO_F_MUX_MODE feature bit is NOT negotiated, the > ? > Ah yes, I'll fix it. >> diff --git a/acknowledgements.tex b/acknowledgements.tex >> index 6c86d12..c4b6844 100644 >> --- a/acknowledgements.tex >> +++ b/acknowledgements.tex >> @@ -26,6 +26,8 @@ Sasha Levin, Oracle \newline >> Sergey Tverdyshev, Thales e-Security \newline >> Stefan Hajnoczi, Red Hat \newline >> Tom Lyon, Samya Systems, Inc. \newline >> +Lei Gong, Huawei \newline >> +Peng Long, Huawei \newline >> \end{oasistitlesection} >> >> The following non-members have provided valuable feedback on this >> @@ -43,4 +45,5 @@ Laura Novich, Red Hat \newline >> Patrick Durusau, Technical Advisory Board, OASIS \newline >> Thomas Huth, IBM \newline >> Yan Vugenfirer, Red Hat / Daynix \newline >> +Halil Pasic, IBM \newline >> \end{oasistitlesection} > > These lists of names are in alphabetical order. Please insert names at > the appropriate place. > OK. >> +If VIRTIO_CRYPTO_F_MUX_MODE is negotioated the device may support both session mode > > s/negotioated/negotiated/ OK. I'll fix some other typos together, thx. -- Regards, Longpeng(Mike)