From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQr1F-0006C2-Pv for qemu-devel@nongnu.org; Mon, 18 Dec 2017 03:43:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQr1C-0007Gm-NA for qemu-devel@nongnu.org; Mon, 18 Dec 2017 03:43:29 -0500 Received: from [45.249.212.32] (port=58490 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eQr1C-0007F1-B0 for qemu-devel@nongnu.org; Mon, 18 Dec 2017 03:43:26 -0500 Message-ID: <5A377F94.5000504@huawei.com> Date: Mon, 18 Dec 2017 16:43:00 +0800 From: "Longpeng (Mike)" MIME-Version: 1.0 References: <1512545840-10256-1-git-send-email-longpeng2@huawei.com> <1512545840-10256-2-git-send-email-longpeng2@huawei.com> <0209e49f-3d81-cbc9-eb07-13654a288a22@linux.vnet.ibm.com> <5A2E8067.4050000@huawei.com> <2b7048c1-e2f8-ab40-c4df-afe5efd8f95d@linux.vnet.ibm.com> In-Reply-To: <2b7048c1-e2f8-ab40-c4df-afe5efd8f95d@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [virtio-dev] Re: [v22 1/2] virtio-crypto: Add virtio crypto device specification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Halil Pasic Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, luonengjun@huawei.com, mst@redhat.com, cornelia.huck@de.ibm.com, stefanha@redhat.com, denglingli@chinamobile.com, Jani.Kokkonen@huawei.com, Ola.Liljedahl@arm.com, Varun.Sethi@freescale.com, xin.zeng@intel.com, brian.a.keating@intel.com, liang.j.ma@intel.com, john.griffin@intel.com, weidong.huang@huawei.com, agraf@suse.de, jasowang@redhat.com, vincent.jardin@6wind.com, arei.gonglei@huawei.com, wangxinxin.wang@huawei.com, jianjay.zhou@huawei.com Hi Halil, On 2017/12/11 21:54, Halil Pasic wrote: > > > On 12/11/2017 01:56 PM, Longpeng (Mike) wrote: >> >> >> On 2017/12/6 19:01, Halil Pasic wrote: >> >>> >>> >>> On 12/06/2017 08:37 AM, Longpeng(Mike) wrote: >>>> +\field{outcome_len} is the size of struct virtio_crypto_session_input or >>>> +ZERO for the session-destroy operation. >>> >>> This ain't correct. It should have been something like virtio_crypto_destroy_session_input. >>> >> >> Hi Halil, >> >> I already fixed this just now. >> Do you have any other comments on v22 ? I'll send v23 tomorrow if no. :) >> > > Did not read the rest of the document. I'm not in the middle of something, > but I wanted to read the operation part these days. I guess, you prefer > sending out v23 over waiting, so I guess I will wait for v23 then. > Sorry, I prefer to wait for more comments on v22. > Some general questions/remarks before you spin v23: > > * I'm not convinced about this 'header' and 'extra parameters' terminology. > Please see https://en.wikipedia.org/wiki/Header_(computing) for header. > I don't think it's fitting for the _flf structs. > Same about the 'extra'. Please see https://www.merriam-webster.com/dictionary/extra > (a : more than is due, usual, or necessary : additional) the things in > _vlf aren't extra at all. Do you intend to stick with is terminology? > If yes why? Please explain how should I read/understand it so that it makes > sense! > I use 'fixed-length paramenters' instead of 'header' and 'variable-length parameters' instead of 'extra parameters' in certain places, but other places are forgotten. BTW, I think this isn't a big problem and structural defect, I hope native speakers could help us. > * Do we want/need to specify any alignment requirement for the > stuff in guest storage (for instance the _flf fields) or be explicit > about no alignment should be assumed (e.g virtio_crypto_mac_create_session_flf.algo > ain't necessarily aligned (in guest memory) as required by uint32_t)? > The _flf fields are all 32bit or 64bit. > * I assume one request is supposed to correspond to one descriptor chain. > Right? If yes, could you tell me, where is this expressed in the spec. > > Halil > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org > > > . > -- Regards, Longpeng(Mike)