From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3277DC64ED6 for ; Mon, 27 Feb 2023 09:12:48 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWZYq-0007eU-2C; Mon, 27 Feb 2023 04:12:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWZYl-0007aS-7A; Mon, 27 Feb 2023 04:12:39 -0500 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pWZYi-0003IN-0I; Mon, 27 Feb 2023 04:12:38 -0500 Received: by mail-ed1-x52d.google.com with SMTP id eg37so22632917edb.12; Mon, 27 Feb 2023 01:12:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=KzaNf1BV/eaGYcmV4bEFPcP3Whyl+deLmO2zFyaQccw=; b=LH49lfLXiIW2oFhywWISwSzcn+81doZKbJhdlXry2AZVwGiIggkcemTAcBOCzzlIvs dPTWIHEkMvCu1BCs1Wh+2bST2tFkoNsJ/Eeks7xgmh6H+fS3pWxMh1J8BjQ1g6j7sv9b K1EdcTslXC1DzdmXSAH8bZi+i/71ieDEAj6jKKss2rnjB1vhFtcNKH1uWY9ygj98gzEv guYn2bZNYAABU3Duwb8tLVioyt0fnGJIdUqOHCjS5sQ/nPNPAkyQC4pCcQmejBd2nuUJ yPhp1BQ/h63F8usJx/3quxYVuXa4cW8LRpP/AV/RKqBWyClrIVzIRTNB5nXhS9XNV/9t 1zMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KzaNf1BV/eaGYcmV4bEFPcP3Whyl+deLmO2zFyaQccw=; b=ExntNHJd8NFgbSc7HQ+wFNM7IY2nixyCOtuIqHmjNmcl44YfPKih52b7lBNnWNEGBS Hs8VjP/p85d9tStAncWJ4vDtS3ZPJl7yymgJcEX2YYC5k4GWPOZGJMc7g/+bjUSRZUHL ZRa0vtbofJYhD2GcWv9n4H/hC3nt8+XtKH+cGeATerNP9zONOe+WtPd06k5aAo/PK7ax T2bUE35ZigPVlV+BzbfyGi0bxSiKRr9GbmJGTyU1zhr3AwhDxsGptRoNNnTkM6ZxpOwL RwmgWweC9tN/2RHzGgwyjDHLI8NeMKq23PpLwHdjP9v5Vq5E1tZFtMD7sORuXLCIohd4 K3OQ== X-Gm-Message-State: AO0yUKUGHUDFq3XY6cmFhKQZaMKIcgFPB0sFNw75qBCY7OQr85Z6V6yp liKJTElXZtvHR9QoTYLX0fU= X-Google-Smtp-Source: AK7set9qr4tc5/SWC9Xk7eV+cHpmxkR2ALIMPC7alNSUUJhtKaMz3xZUVzUpuJYNHtAisJ7ADzq0DA== X-Received: by 2002:a17:906:4914:b0:8b1:7eaf:4708 with SMTP id b20-20020a170906491400b008b17eaf4708mr36469864ejq.65.1677489153649; Mon, 27 Feb 2023 01:12:33 -0800 (PST) Received: from [127.0.0.1] (dynamic-078-055-154-008.78.55.pool.telefonica.de. [78.55.154.8]) by smtp.gmail.com with ESMTPSA id gx16-20020a1709068a5000b008b69aa62efcsm2994179ejc.62.2023.02.27.01.12.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 01:12:33 -0800 (PST) Date: Mon, 27 Feb 2023 09:12:25 +0000 From: Bernhard Beschow To: "Michael S. Tsirkin" CC: qemu-devel@nongnu.org, Marcel Apfelbaum , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Gerd Hoffmann , Aurelien Jarno , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , David Hildenbrand , Peter Xu , qemu-ppc@nongnu.org, qemu-block@nongnu.org, John Snow , Paolo Bonzini Subject: Re: [PATCH v2 00/10] Resolve isabus global In-Reply-To: References: <20230126211740.66874-1-shentey@gmail.com> <20230224112230-mutt-send-email-mst@kernel.org> Message-ID: <5A6D6A22-C45C-478E-B1F7-B5EEC2A69205@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::52d; envelope-from=shentey@gmail.com; helo=mail-ed1-x52d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 26=2E Februar 2023 20:38:24 UTC schrieb Bernhard Beschow : > > >Am 24=2E Februar 2023 16:22:48 UTC schrieb "Michael S=2E Tsirkin" : >>On Thu, Jan 26, 2023 at 10:17:30PM +0100, Bernhard Beschow wrote: >>> This series resolves the global "isabus" variable and is basically a v= 2 of [1]=2E >>> Note that the majority of the work consists of fixing ISA API calls in= PIIX IDE >>> which implicitly rely on the usage of the isabus global=2E >>>=20 >>> Rather than adding an ISABus pointer in PCIIDEState as in [1] this ser= ies uses >>> a qemu_irq array which is roughly the approach outlined in [2]=2E More= over, this >>> series considers backwards compatibility for user-created PIIX IDE >>> "Frankensten" devices by fishing out TYPE_ISA_BUS from the QOM tree in= side >>> the PIIX IDE device model=2E This hack can be removed again once a dep= recation >>> period of user-createable PIIX IDE devices is over=2E This deprecation= wasn't >>> announced yet but now might be a good time=2E >>>=20 >>> This series is structured as follows: The first three patches massage = the ISA >>> code for patch 8=2E Patches 4-8 change the PIIX IDE device models to n= ot use the >>> isabus global implicitly=2E Finally, the last two patches clan up and = remove the >>> isabus singleton=2E >> >>I expect there will be a v3 of this, right? > >I would do it and I could rebase onto master if necessary=2E However, ano= ther series unrelated to this one but doing essentially the same thing with= less backwards promises went through various iterations in the meantime=2E= I don't know what the plan is=2E Phil, how shall we proceed? What's holding back the PIIX consolidation? It= was fully reviewed at the beginning of the development window=2E Now the f= reeze is just a couple of days ahead=2E Best regards, Bernhard > >Best regards, >Bernhard > >> >> >>> Based-on: <20230109172347=2E1830-1-shentey@gmail=2Ecom> >>> 'Consolidate PIIX south bridges' >>>=20 >>> v2: >>> - Big rework sticking closer to [1], giving it more credit and reusing= one patch >>> - Add io port cleanup >>> - Rebase onto [4] so changes to PIIX could be done once and centrally >>>=20 >>> Testing done: >>> * `make check` >>> * `=2E/qemu-system-x86_64 -M x-remote -device piix3-ide` still fails g= racefully with >>> `qemu-system-x86_64: -device piix3-ide: No ISA bus found while piix3= -ide requires one` >>> * `qemu-system-x86_64 -M pc -m 2G -cdrom manjaro-kde-21=2E3=2E2-220704= -linux515=2Eiso` >>> * `qemu-system-x86_64 -M q35 -m 2G -device piix4-ide -cdrom \ >>> manjaro-kde-21=2E3=2E2-220704-linux515=2Eiso` >>> * `qemu-system-mips64el -M malta -kernel vmlinux-3=2E2=2E0-4-5kc-malta= -hda \ >>> debian_wheezy_mipsel_standard=2Eqcow2 -append "root=3D/dev/sda1 cons= ole=3DttyS0"` >>>=20 >>> [1] https://patchew=2Eorg/QEMU/20210518215545=2E1793947-1-philmd@redha= t=2Ecom/ >>> [2] https://lists=2Enongnu=2Eorg/archive/html/qemu-devel/2020-03/msg01= 707=2Ehtml >>> [3] https://people=2Edebian=2Eorg/~aurel32/qemu/mips/ >>> [4] https://patchew=2Eorg/QEMU/20230109172347=2E1830-1-shentey@gmail= =2Ecom/ >>>=20 >>> Bernhard Beschow (9): >>> softmmu/ioport: Move portio_list_init() in front of portio_list_add(= ) >>> softmmu/ioport: Merge portio_list_add() into portio_list_init() >>> softmmu/ioport: Remove unused functions >>> hw/ide/piix: Disuse isa_get_irq() >>> Revert "hw/ide: Fix crash when plugging a piix3-ide device into the >>> x-remote machine" >>> hw/ide/pci: Add PCIIDEState::isa_irqs[] >>> hw/ide/piix: Require an ISABus only for user-created instances >>> hw/ide: Let ide_init_ioport() take a MemoryRegion argument instead o= f >>> ISADevice >>> hw/isa/isa-bus: Resolve isabus global >>>=20 >>> Philippe Mathieu-Daud=C3=A9 (1): >>> hw/isa: Remove use of global isa bus >>>=20 >>> include/exec/ioport=2Eh | 8 ++--- >>> include/hw/ide/internal=2Eh | 3 +- >>> include/hw/ide/pci=2Eh | 2 ++ >>> include/hw/isa/isa=2Eh | 15 ++++---- >>> hw/audio/adlib=2Ec | 4 +-- >>> hw/display/qxl=2Ec | 5 ++- >>> hw/display/vga=2Ec | 8 ++--- >>> hw/dma/i82374=2Ec | 6 ++-- >>> hw/ide/ioport=2Ec | 19 +++++----- >>> hw/ide/isa=2Ec | 4 ++- >>> hw/ide/piix=2Ec | 75 +++++++++++++++++++++++++++++++-----= --- >>> hw/isa/isa-bus=2Ec | 54 +++++++++++++++------------- >>> hw/isa/piix=2Ec | 5 +++ >>> hw/watchdog/wdt_ib700=2Ec | 4 +-- >>> softmmu/ioport=2Ec | 70 +++++++++++------------------------- >>> 15 files changed, 149 insertions(+), 133 deletions(-) >>>=20 >>> --=20 >>> 2=2E39=2E1 >>>=20 >>