From: Wei Wang <wei.w.wang@intel.com>
To: Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org, quintela@redhat.com, dgilbert@redhat.com,
peterx@redhat.com
Cc: gloryxiao@tencent.com, kevin.tian@intel.com, yi.y.sun@intel.com
Subject: Re: [PATCH v1 2/2] migration/xbzrle: add encoding rate
Date: Tue, 21 Apr 2020 09:14:04 +0800 [thread overview]
Message-ID: <5E9E48DC.3030609@intel.com> (raw)
In-Reply-To: <c291eede-8187-5f95-7939-3bdcf4a832e2@redhat.com>
On 04/20/2020 10:53 PM, Eric Blake wrote:
> On 4/19/20 10:06 PM, Wei Wang wrote:
>> Users may need to check the xbzrle encoding rate to know if the guest
>> memory is xbzrle encoding-friendly, and dynamically turn off the
>> encoding if the encoding rate is low.
>>
>> Signed-off-by: Yi Sun <yi.y.sun@intel.com>
>> Signed-off-by: Wei Wang <wei.w.wang@intel.com>
>> ---
>
> In addition to Dan's review comments,
>
>> +++ b/qapi/migration.json
>> @@ -70,6 +70,8 @@
>> #
>> # @cache-miss-rate: rate of cache miss (since 2.1)
>> #
>> +# @encoding-rate: rate of cache miss
>
> This is missing a '(since 5.1)' tag.
OK, will add it, thanks.
Best,
Wei
prev parent reply other threads:[~2020-04-21 1:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 3:06 [PATCH v1 0/2] Migration xbzrle changes Wei Wang
2020-04-20 3:06 ` [PATCH v1 1/2] migration/xbzrle: replace transferred xbzrle bytes with encoded bytes Wei Wang
2020-04-20 9:29 ` Daniel P. Berrangé
2020-04-20 9:49 ` Wei Wang
2020-04-21 19:21 ` Dr. David Alan Gilbert
2020-04-22 2:51 ` Wei Wang
2020-04-24 10:47 ` Dr. David Alan Gilbert
2020-04-27 7:26 ` Wei Wang
2020-04-20 3:06 ` [PATCH v1 2/2] migration/xbzrle: add encoding rate Wei Wang
2020-04-20 9:30 ` Daniel P. Berrangé
2020-04-20 14:53 ` Eric Blake
2020-04-21 1:14 ` Wei Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5E9E48DC.3030609@intel.com \
--to=wei.w.wang@intel.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=gloryxiao@tencent.com \
--cc=kevin.tian@intel.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=yi.y.sun@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).