From: AlexChen <alex.chen@huawei.com>
To: "\"Daniel P. Berrangé\"" <berrange@redhat.com>
Cc: zhengchuan@huawei.com, pbonzini@redhat.com,
qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com
Subject: Re: oslib-posix：Fix handle fd leak in qemu_write_pidfile()
Date: Thu, 27 Aug 2020 10:40:39 +0800 [thread overview]
Message-ID: <5F471D27.8040608@huawei.com> (raw)
In-Reply-To: <20200826101835.GM168515@redhat.com>
On 2020/8/26 18:18, Daniel P. Berrangé wrote:
> On Wed, Aug 26, 2020 at 06:14:48PM +0800, AlexChen wrote:
>> > From: alexchen <alex.chen@huawei.com>
>> >
>> > The fd will leak when (a.st_ino == b.st_ino) is true, fix it.
> That is *INTENTIONAL*. We're holding a lock on the file and the
> lock exists only while the FD is open. When QEMU exists, the FD
> is closed and the lock is released. There is no leak.
>
OK, I got it, thanks.
Thanks
Alex
prev parent reply other threads:[~2020-08-27 2:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 10:14 oslib-posix：Fix handle fd leak in qemu_write_pidfile() AlexChen
2020-08-26 10:18 ` Daniel P. Berrangé
2020-08-27 2:40 ` AlexChen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F471D27.8040608@huawei.com \
--to=alex.chen@huawei.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).