From: AlexChen <alex.chen@huawei.com>
To: <alex.bennee@linaro.org>, Laurent Vivier <laurent@vivier.eu>,
<mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, zhengchuan@huawei.com,
qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com
Subject: [PATCH 2/2] plugins: Fix two resource leaks in connect_socket()
Date: Wed, 28 Oct 2020 21:45:21 +0800 [thread overview]
Message-ID: <5F9975F1.4080205@huawei.com> (raw)
Either accept() fails or exits normally, we need to close the fd.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: AlexChen <alex.chen@huawei.com>
---
contrib/plugins/lockstep.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index 319bd44b83..5aad50869d 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -268,11 +268,13 @@ static bool setup_socket(const char *path)
socket_fd = accept(fd, NULL, NULL);
if (socket_fd < 0 && errno != EINTR) {
perror("accept socket");
+ close(fd);
return false;
}
qemu_plugin_outs("setup_socket::ready\n");
+ close(fd);
return true;
}
--
2.19.1
next reply other threads:[~2020-10-28 13:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 13:45 AlexChen [this message]
2020-11-05 6:54 ` [PATCH 2/2] plugins: Fix two resource leaks in connect_socket() AlexChen
2020-11-16 16:50 ` Thomas Huth
2020-11-17 1:13 ` Alex Chen
2020-11-17 11:35 ` Alex Bennée
2020-11-17 11:36 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F9975F1.4080205@huawei.com \
--to=alex.chen@huawei.com \
--cc=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).