* block: Remove unused include
@ 2020-10-21 9:12 AlexChen
2020-10-29 12:42 ` AlexChen
2020-11-03 13:26 ` Max Reitz
0 siblings, 2 replies; 4+ messages in thread
From: AlexChen @ 2020-10-21 9:12 UTC (permalink / raw)
To: kwolf, mreitz; +Cc: qemu-devel, qemu-block
The "qemu-common.h" include is not used, remove it.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: AlexChen <alex.chen@huawei.com>
---
block/dmg-lzfse.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/dmg-lzfse.c b/block/dmg-lzfse.c
index 19d25bc646..6798cf4fbf 100644
--- a/block/dmg-lzfse.c
+++ b/block/dmg-lzfse.c
@@ -22,7 +22,6 @@
* THE SOFTWARE.
*/
#include "qemu/osdep.h"
-#include "qemu-common.h"
#include "dmg.h"
#include <lzfse.h>
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: block: Remove unused include
2020-10-21 9:12 block: Remove unused include AlexChen
@ 2020-10-29 12:42 ` AlexChen
2020-11-03 13:26 ` Max Reitz
1 sibling, 0 replies; 4+ messages in thread
From: AlexChen @ 2020-10-29 12:42 UTC (permalink / raw)
To: kwolf, mreitz; +Cc: qemu-trivial, qemu-devel, qemu-block
Kindly ping.
Thanks,
Alex
On 2020/10/21 17:12, AlexChen wrote:
> The "qemu-common.h" include is not used, remove it.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: AlexChen <alex.chen@huawei.com>
> ---
> block/dmg-lzfse.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/dmg-lzfse.c b/block/dmg-lzfse.c
> index 19d25bc646..6798cf4fbf 100644
> --- a/block/dmg-lzfse.c
> +++ b/block/dmg-lzfse.c
> @@ -22,7 +22,6 @@
> * THE SOFTWARE.
> */
> #include "qemu/osdep.h"
> -#include "qemu-common.h"
> #include "dmg.h"
> #include <lzfse.h>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: block: Remove unused include
2020-10-21 9:12 block: Remove unused include AlexChen
2020-10-29 12:42 ` AlexChen
@ 2020-11-03 13:26 ` Max Reitz
2020-11-03 13:42 ` AlexChen
1 sibling, 1 reply; 4+ messages in thread
From: Max Reitz @ 2020-11-03 13:26 UTC (permalink / raw)
To: AlexChen, kwolf; +Cc: qemu-devel, qemu-block
On 21.10.20 11:12, AlexChen wrote:
> The "qemu-common.h" include is not used, remove it.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: AlexChen <alex.chen@huawei.com>
> ---
> block/dmg-lzfse.c | 1 -
> 1 file changed, 1 deletion(-)
Thanks, I’ve applied this patch to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Please note (for future patches) that all patches’ subjects should by
prefixed by “[PATCH]”, as done by git format-patch (see
https://wiki.qemu.org/Contribute/SubmitAPatch#Use_git_format-patch).
Max
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: block: Remove unused include
2020-11-03 13:26 ` Max Reitz
@ 2020-11-03 13:42 ` AlexChen
0 siblings, 0 replies; 4+ messages in thread
From: AlexChen @ 2020-11-03 13:42 UTC (permalink / raw)
To: Max Reitz; +Cc: kwolf, qemu-devel, qemu-block
On 2020/11/3 21:26, Max Reitz wrote:
> On 21.10.20 11:12, AlexChen wrote:
>> The "qemu-common.h" include is not used, remove it.
>>
>> Reported-by: Euler Robot <euler.robot@huawei.com>
>> Signed-off-by: AlexChen <alex.chen@huawei.com>
>> ---
>> block/dmg-lzfse.c | 1 -
>> 1 file changed, 1 deletion(-)
>
> Thanks, I’ve applied this patch to my block branch:
>
> https://git.xanclic.moe/XanClic/qemu/commits/branch/block
>
> Please note (for future patches) that all patches’ subjects should by
> prefixed by “[PATCH]”, as done by git format-patch (see
> https://wiki.qemu.org/Contribute/SubmitAPatch#Use_git_format-patch).
>
Oh, this is my fault, I will pay attention to this in my subsequent patches.
Thanks,
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-03 13:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-21 9:12 block: Remove unused include AlexChen
2020-10-29 12:42 ` AlexChen
2020-11-03 13:26 ` Max Reitz
2020-11-03 13:42 ` AlexChen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).