From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bernhard Beschow <shentey@gmail.com>, qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Paul Durrant" <paul@xen.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Anthony Perard" <anthony.perard@citrix.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Chuck Zmudzinski" <brchuckz@aol.com>
Subject: Re: [PATCH v2 1/6] include/hw/xen/xen: Rename xen_piix3_set_irq() to xen_intx_set_irq()
Date: Wed, 4 Jan 2023 16:17:00 +0100 [thread overview]
Message-ID: <5a1b4b87-e6eb-de5d-ae1f-b648b6a7fc58@linaro.org> (raw)
In-Reply-To: <20230104144437.27479-2-shentey@gmail.com>
On 4/1/23 15:44, Bernhard Beschow wrote:
> xen_piix3_set_irq() isn't PIIX specific: PIIX is a single PCI device
> while xen_piix3_set_irq() maps multiple PCI devices to their respective
> IRQs, which is board-specific. Rename xen_piix3_set_irq() to communicate
> this.
>
> Also rename XEN_PIIX_NUM_PIRQS to XEN_IOAPIC_NUM_PIRQS since the Xen's
> IOAPIC rather than PIIX has this many interrupt routes.
>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
> hw/i386/xen/xen-hvm.c | 2 +-
> hw/isa/piix.c | 4 ++--
> include/hw/xen/xen.h | 2 +-
> stubs/xen-hw-stub.c | 2 +-
> 4 files changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-01-04 15:17 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 14:44 [PATCH v2 0/6] Resolve TYPE_PIIX3_XEN_DEVICE Bernhard Beschow
2023-01-04 14:44 ` [PATCH v2 1/6] include/hw/xen/xen: Rename xen_piix3_set_irq() to xen_intx_set_irq() Bernhard Beschow
2023-01-04 15:17 ` Philippe Mathieu-Daudé [this message]
2023-01-04 14:44 ` [PATCH v2 2/6] hw/isa/piix: Reuse piix3_realize() in piix3_xen_realize() Bernhard Beschow
2023-01-04 14:44 ` [PATCH v2 3/6] hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3 Bernhard Beschow
2023-01-04 15:18 ` Philippe Mathieu-Daudé
2023-01-06 17:35 ` David Woodhouse
2023-01-06 17:46 ` Chuck Zmudzinski
2023-01-06 18:39 ` Chuck Zmudzinski
2023-01-07 10:58 ` Bernhard Beschow
2023-01-04 14:44 ` [PATCH v2 4/6] hw/isa/piix: Avoid Xen-specific variant of piix_write_config() Bernhard Beschow
2023-01-04 14:44 ` [PATCH v2 5/6] hw/isa/piix: Resolve redundant k->config_write assignments Bernhard Beschow
2023-01-04 15:19 ` Philippe Mathieu-Daudé
2023-01-04 14:44 ` [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE Bernhard Beschow
2023-01-04 15:35 ` Philippe Mathieu-Daudé
2023-01-04 17:54 ` Chuck Zmudzinski
2023-01-04 18:48 ` Philippe Mathieu-Daudé
2023-01-04 19:29 ` Chuck Zmudzinski
2023-01-04 20:31 ` Bernhard Beschow
2023-01-04 20:57 ` Chuck Zmudzinski
2023-01-04 22:18 ` Philippe Mathieu-Daudé
2023-01-05 2:34 ` Chuck Zmudzinski
2023-01-04 20:44 ` Bernhard Beschow
2023-01-04 20:50 ` Chuck Zmudzinski
2023-01-06 11:57 ` Bernhard Beschow
2023-01-06 12:25 ` Philippe Mathieu-Daudé
2023-01-06 19:08 ` Chuck Zmudzinski
2023-01-06 23:04 ` Chuck Zmudzinski
2023-01-07 1:08 ` Chuck Zmudzinski
2023-01-07 11:05 ` Bernhard Beschow
2023-01-07 18:08 ` Chuck Zmudzinski
2023-01-04 16:42 ` Chuck Zmudzinski
2023-01-04 19:45 ` Bernhard Beschow
2023-01-04 22:35 ` Philippe Mathieu-Daudé
2023-01-05 1:57 ` Chuck Zmudzinski
2023-01-05 2:25 ` Chuck Zmudzinski
2023-01-17 22:51 ` [PATCH v2 0/6] Resolve TYPE_PIIX3_XEN_DEVICE Bernhard Beschow
2023-01-18 10:13 ` Michael S. Tsirkin
2023-01-24 16:11 ` Anthony PERARD via
2023-01-24 17:07 ` Bernhard Beschow
2023-02-01 8:11 ` Bernhard Beschow
2023-02-09 21:53 ` Bernhard Beschow
2023-03-11 22:20 ` Chuck Zmudzinski
2023-03-12 9:22 ` Bernhard Beschow
2023-03-12 21:02 ` Chuck Zmudzinski
2023-03-12 22:46 ` Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a1b4b87-e6eb-de5d-ae1f-b648b6a7fc58@linaro.org \
--to=philmd@linaro.org \
--cc=anthony.perard@citrix.com \
--cc=aurelien@aurel32.net \
--cc=brchuckz@aol.com \
--cc=eduardo@habkost.net \
--cc=hpoussin@reactos.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).