Re: [Qemu-devel] [PULL v2 11/11] disas: Add capstone as submodule

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2009 bytes --]

On 10/26/2017 05:00 AM, Richard Henderson wrote:
> Do not require the submodule, but use it if present.  Allow the
> command-line to override system or git submodule either way.
> 
> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  Makefile    | 15 ++++++++++++++
>  .gitmodules |  3 +++
>  capstone    |  1 +
>  configure   | 68 +++++++++++++++++++++++++++++++++++++++++++++++++++----------
>  4 files changed, 76 insertions(+), 11 deletions(-)
>  create mode 160000 capstone

I'm seeing a couple of anomalies which I think are due to this series.
One is that make is now always noisy, even when there is nothing to do:

$ make
make[1]: '/home/eblake/qemu/capstone/libcapstone.a' is up to date.
$

It would be really nice to silence that line when things are up-to-date,
the way it used to be.

The other is that, at least on my setup (Fedora 27 with 'capstone' not
installed), I get a spurious 'make check-unit' failure (part of 'make
check'):

  GTESTER tests/check-qdict
tests/check-qdict: error while loading shared libraries:
libcapstone.so.3: cannot open shared object file: No such file or directory
make: *** [/home/eblake/qemu/tests/Makefile.include:864:
check-tests/check-qdict] Error 1
make: *** Waiting for unfinished jobs....


but if I then 'dnf install capstone-devel', running 'make check'
succeeds.  I'm not sure why the in-tree library when using the submodule
is not letting the testsuite run, but suspect that our CI engine and
most developers aren't seeing the failure because they have installed
the distro library and are therefore not relying on the submodule.

It's probably too late to change anything for 2.11, but it's worth
seeing if it can be improved during 2.12.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]