From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36730) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGLAc-0006ER-RP for qemu-devel@nongnu.org; Sat, 18 Jul 2015 02:00:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZGLAc-00048p-1i for qemu-devel@nongnu.org; Sat, 18 Jul 2015 02:00:22 -0400 Received: from mail-pd0-x22d.google.com ([2607:f8b0:400e:c02::22d]:33988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGLAb-00048Y-RV for qemu-devel@nongnu.org; Sat, 18 Jul 2015 02:00:21 -0400 Received: by pdbbh15 with SMTP id bh15so26475756pdb.1 for ; Fri, 17 Jul 2015 23:00:20 -0700 (PDT) From: Peter Crosthwaite Date: Fri, 17 Jul 2015 23:00:06 -0700 Message-Id: <5a39caaa44a0a2f6b9b5591fd48dd9c69f802c4e.1437197974.git.crosthwaite.peter@gmail.com> In-Reply-To: References: In-Reply-To: References: Subject: [Qemu-devel] [PATCH 2/2] arm: Remove hw_error() usages. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, Peter Crosthwaite All of these hw_errors are fatal and indicate something wrong with QEMU implementation. Convert to g_assert_not_reached. Signed-off-by: Peter Crosthwaite --- Dropped the error messages as they are not hugely useful outside of a debug flow. --- target-arm/cpu.c | 4 ++-- target-arm/helper.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target-arm/cpu.c b/target-arm/cpu.c index c4b8448..8b5471a 100644 --- a/target-arm/cpu.c +++ b/target-arm/cpu.c @@ -325,7 +325,7 @@ static void arm_cpu_set_irq(void *opaque, int irq, int level) } break; default: - hw_error("arm_cpu_set_irq: Bad interrupt line %d\n", irq); + g_assert_not_reached(); } } @@ -344,7 +344,7 @@ static void arm_cpu_kvm_set_irq(void *opaque, int irq, int level) kvm_irq |= KVM_ARM_IRQ_CPU_FIQ; break; default: - hw_error("arm_cpu_kvm_set_irq: Bad interrupt line %d\n", irq); + g_assert_not_reached(); } kvm_irq |= cs->cpu_index << KVM_ARM_IRQ_VCPU_SHIFT; kvm_set_irq(kvm_state, kvm_irq, level ? 1 : 0); diff --git a/target-arm/helper.c b/target-arm/helper.c index b2f3db9..662e2bb 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -3997,7 +3997,7 @@ int bank_number(int mode) case ARM_CPU_MODE_MON: return 7; } - hw_error("bank number requested for bad CPSR mode value 0x%x\n", mode); + g_assert_not_reached(); } void switch_mode(CPUARMState *env, int mode) -- 1.9.1