From: Richard Henderson <richard.henderson@linaro.org>
To: junyan.he@gmx.com, qemu-devel@nongnu.org
Cc: ehabkost@redhat.com, imammedo@redhat.com, pbonzini@redhat.com,
crosthwaite.peter@gmail.com, xiaoguangrong.eric@gmail.com,
mst@redhat.com, quintela@redhat.com, dgilbert@redhat.com,
stefanha@redhat.com, yi.z.zhang@intel.com,
Junyan He <junyan.he@intel.com>,
Haozhong Zhang <haozhong.zhang@intel.com>
Subject: Re: [Qemu-devel] [PATCH 2/7 V10] memory, exec: switch file ram allocation functions to 'flags' parameters
Date: Tue, 17 Jul 2018 09:02:31 -0700 [thread overview]
Message-ID: <5a3a6160-e7ed-0bfb-7f52-a067a9a0762f@linaro.org> (raw)
In-Reply-To: <1531809130-31088-3-git-send-email-junyan.he@gmx.com>
On 07/16/2018 11:32 PM, junyan.he@gmx.com wrote:
> RAMBlock *qemu_ram_alloc_from_fd(ram_addr_t size, MemoryRegion *mr,
> - bool share, int fd,
> + uint64_t ram_flags, int fd,
> Error **errp)
> {
> RAMBlock *new_block;
> @@ -2280,14 +2280,14 @@ RAMBlock *qemu_ram_alloc_from_fd(ram_addr_t size, MemoryRegion *mr,
> new_block->mr = mr;
> new_block->used_length = size;
> new_block->max_length = size;
> - new_block->flags = share ? RAM_SHARED : 0;
> + new_block->flags = ram_flags;
The type of "flags" within RAMBlock is uint32_t.
You should either change the member type in the struct,
or change the argument type in all of these functions.
More likely the latter, since you seem to have just
five used bits at the moment.
r~
next prev parent reply other threads:[~2018-07-17 16:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 6:32 [Qemu-devel] [PATCH 0/7 V10] nvdimm: guarantee persistence of QEMU writes to persistent memory junyan.he
2018-07-17 6:32 ` [Qemu-devel] [PATCH 1/7 V10] memory, exec: Expose all memory block related flags junyan.he
2018-07-17 15:58 ` Richard Henderson
2018-07-17 6:32 ` [Qemu-devel] [PATCH 2/7 V10] memory, exec: switch file ram allocation functions to 'flags' parameters junyan.he
2018-07-17 16:02 ` Richard Henderson [this message]
2018-07-18 5:34 ` He, Junyan
2018-07-17 6:32 ` [Qemu-devel] [PATCH 3/7 V10] configure: add libpmem support junyan.he
2018-07-17 16:05 ` Richard Henderson
2018-07-17 6:32 ` [Qemu-devel] [PATCH 4/7 V10] hostmem-file: add the 'pmem' option junyan.he
2018-07-17 16:46 ` Richard Henderson
2018-07-17 6:32 ` [Qemu-devel] [PATCH 5/7 V10] mem/nvdimm: ensure write persistence to PMEM in label emulation junyan.he
2018-07-17 17:00 ` Richard Henderson
2018-07-17 6:32 ` [Qemu-devel] [PATCH 6/7 V10] migration/ram: Add check and info message to nvdimm post copy junyan.he
2018-07-17 6:32 ` [Qemu-devel] [PATCH 7/7 V10] migration/ram: ensure write persistence on loading all data to PMEM junyan.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a3a6160-e7ed-0bfb-7f52-a067a9a0762f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=haozhong.zhang@intel.com \
--cc=imammedo@redhat.com \
--cc=junyan.he@gmx.com \
--cc=junyan.he@intel.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
--cc=yi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).