From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGiEt-0005p0-Fq for qemu-devel@nongnu.org; Mon, 20 Nov 2017 04:19:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGiEq-00051H-6X for qemu-devel@nongnu.org; Mon, 20 Nov 2017 04:19:39 -0500 References: <20171120091520.86128-1-borntraeger@de.ibm.com> From: Alexander Graf Message-ID: <5a4be37f-29b5-1d0d-91ab-9cb15c93e088@suse.de> Date: Mon, 20 Nov 2017 10:19:31 +0100 MIME-Version: 1.0 In-Reply-To: <20171120091520.86128-1-borntraeger@de.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: build s390 bios with -fno-zero-initialized-in-bss List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger , Cornelia Huck Cc: qemu-devel , qemu-s390x , Halil Pasic , Richard Henderson , Thomas Huth On 11/20/2017 10:15 AM, Christian Borntraeger wrote: > The QEMU ELF loader does not initialize the bss segment. This has > triggered several bugs in the past, e.g. see commit 5d739a4787a5 > ("s390-ccw.img: Fix sporadic errors with ccw boot image - initialize > css"). > > Instead of fixing these things one-by-one we can build the BIOS > with -fno-zero-initialized-in-bss. This will move the zero variables > also into the data segment, which is then part of a LOAD section. Doesn't this bloat the firmware? Why don't we just manually clear bss in the firmware itself? It's what all other firmwares do :) Alex