From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, berto@igalia.com, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH v6 0/8] qcow2: encryption threads
Date: Thu, 9 May 2019 16:56:46 +0200 [thread overview]
Message-ID: <5a643d95-3732-e22d-7cc5-122ae5792641@redhat.com> (raw)
In-Reply-To: <20190506142741.41731-1-vsementsov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 1609 bytes --]
On 06.05.19 16:27, Vladimir Sementsov-Ogievskiy wrote:
> v6:
> - Rebase on master, so 02 changed to reflect changes in
> qcow2_compress(), keep r-b.
> - Rewrite 06 to even simpler locking [Max], drop r-b
> Drop following
> "qcow2: qcow2_co_preadv: skip using hd_qiov when possible", I'll do
> it in my other coming soon series, and it is actually unrelated to
> current.
> - Drop controversial perf test, hope I'll return to this topic, but not
> in context of these series.
> - Add Max's r-b's to all here, except 06
>
> Vladimir Sementsov-Ogievskiy (8):
> qcow2.h: add missing include
> qcow2: add separate file for threaded data processing functions
> qcow2-threads: use thread_pool_submit_co
> qcow2-threads: qcow2_co_do_compress: protect queuing by mutex
> qcow2-threads: split out generic path
> qcow2: qcow2_co_preadv: improve locking
> qcow2: bdrv_co_pwritev: move encryption code out of the lock
> qcow2: do encryption in threads
>
> block/qcow2.h | 20 ++-
> block/qcow2-bitmap.c | 1 -
> block/qcow2-cache.c | 1 -
> block/qcow2-cluster.c | 8 +-
> block/qcow2-refcount.c | 1 -
> block/qcow2-snapshot.c | 1 -
> block/qcow2-threads.c | 268 +++++++++++++++++++++++++++++++++++++++++
> block/qcow2.c | 241 +++++-------------------------------
> block/Makefile.objs | 2 +-
> 9 files changed, 321 insertions(+), 222 deletions(-)
> create mode 100644 block/qcow2-threads.c
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-05-09 14:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 14:27 [Qemu-devel] [PATCH v6 0/8] qcow2: encryption threads Vladimir Sementsov-Ogievskiy
2019-05-06 14:27 ` [Qemu-devel] [PATCH v6 1/8] qcow2.h: add missing include Vladimir Sementsov-Ogievskiy
2019-05-06 14:27 ` [Qemu-devel] [PATCH v6 2/8] qcow2: add separate file for threaded data processing functions Vladimir Sementsov-Ogievskiy
2019-05-06 14:27 ` [Qemu-devel] [PATCH v6 3/8] qcow2-threads: use thread_pool_submit_co Vladimir Sementsov-Ogievskiy
2019-05-06 14:27 ` [Qemu-devel] [PATCH v6 4/8] qcow2-threads: qcow2_co_do_compress: protect queuing by mutex Vladimir Sementsov-Ogievskiy
2019-05-06 14:27 ` [Qemu-devel] [PATCH v6 5/8] qcow2-threads: split out generic path Vladimir Sementsov-Ogievskiy
2019-05-06 14:27 ` [Qemu-devel] [PATCH v6 6/8] qcow2: qcow2_co_preadv: improve locking Vladimir Sementsov-Ogievskiy
2019-05-09 12:11 ` Alberto Garcia
2019-05-06 14:27 ` [Qemu-devel] [PATCH v6 7/8] qcow2: bdrv_co_pwritev: move encryption code out of the lock Vladimir Sementsov-Ogievskiy
2019-05-06 14:27 ` [Qemu-devel] [PATCH v6 8/8] qcow2: do encryption in threads Vladimir Sementsov-Ogievskiy
2019-05-09 14:56 ` Max Reitz [this message]
2019-05-13 9:56 ` [Qemu-devel] [PATCH v6 0/8] qcow2: encryption threads Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a643d95-3732-e22d-7cc5-122ae5792641@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).