From: Vasant Hegde <vasant.hegde@amd.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
Santosh Shukla <santosh.shukla@amd.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Zhao Liu <zhao1.liu@intel.com>,
Eduardo Habkost <eduardo@habkost.net>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Sairaj Kodilkar <sarunkod@amd.com>,
Daniel Hoffman <dhoff749@gmail.com>
Subject: Re: [PATCH-for-10.0 v2] hw/i386/amd_iommu: Simplify non-KVM checks on XTSup feature
Date: Wed, 18 Dec 2024 14:46:50 +0530 [thread overview]
Message-ID: <5a917008-95d4-4adb-99fb-37e626c38fbc@amd.com> (raw)
In-Reply-To: <20241129155802.35534-1-philmd@linaro.org>
On 11/29/2024 9:28 PM, Philippe Mathieu-Daudé wrote:
> Generic code wanting to access KVM specific methods should
> do so being protected by the 'kvm_enabled()' helper.
>
> Doing so avoid link failures when optimization is disabled
> (using --enable-debug), see for example commits c04cfb4596a
> ("hw/i386: fix short-circuit logic with non-optimizing builds")
> and 0266aef8cd6 ("amd_iommu: Fix kvm_enable_x2apic link error
> with clang in non-KVM builds").
>
> XTSup feature depends on KVM, so protect the whole block
> checking the XTSup feature with a check on whether KVM is
> enabled.
>
> Since x86_cpus_init() already checks APIC ID > 255 imply
> kernel support for irqchip and X2APIC, remove the confuse
> and unlikely reachable "AMD IOMMU xtsup=on requires support
> on the KVM side" message.
>
> Fix a type in "configuration" in error message.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Thanks for the fix. Looks good to me.
Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>
-Vasant
next prev parent reply other threads:[~2024-12-18 13:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 15:58 [PATCH-for-10.0 v2] hw/i386/amd_iommu: Simplify non-KVM checks on XTSup feature Philippe Mathieu-Daudé
2024-12-18 9:16 ` Vasant Hegde [this message]
2024-12-31 17:36 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a917008-95d4-4adb-99fb-37e626c38fbc@amd.com \
--to=vasant.hegde@amd.com \
--cc=dhoff749@gmail.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=santosh.shukla@amd.com \
--cc=sarunkod@amd.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).