qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] scripts/coverity-scan/COMPONENTS.md: Update paths to match gitlab CI
Date: Tue, 4 Jun 2024 17:09:04 +0200	[thread overview]
Message-ID: <5a935eea-fc4f-4b11-b981-8670f03615f0@linaro.org> (raw)
In-Reply-To: <CAFEAcA8Wv5YCpdee5GZzsAj824WRUxPb6mmLLSQvXV6S68aLkQ@mail.gmail.com>

On 4/6/24 15:32, Peter Maydell wrote:
> On Fri, 31 May 2024 at 16:17, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>>
>> Hi Peter,
>>
>> On 31/5/24 16:21, Peter Maydell wrote:
> 
>>> If there are any other changes we want to make to our component
>>> regexes, now would be a great time to suggest them, because this
>>> change is going to involve "delete every existing component and
>>> recreate"...
>>> ---
>>>    scripts/coverity-scan/COMPONENTS.md | 104 ++++++++++++++--------------
>>>    1 file changed, 52 insertions(+), 52 deletions(-)
>>
>>
>>> diff --git a/scripts/coverity-scan/COMPONENTS.md b/scripts/coverity-scan/COMPONENTS.md
>>> index 1537e49cd5a..98d4bcd6a50 100644
>>> --- a/scripts/coverity-scan/COMPONENTS.md
>>> +++ b/scripts/coverity-scan/COMPONENTS.md
>>> @@ -1,157 +1,157 @@
>>>    This is the list of currently configured Coverity components:
>>
>>
>>>    block
>>> -  ~ (/qemu)?(/block.*|(/include?)/(block|storage-daemon)/.*|(/include)?/hw/(block|ide|nvme)/.*|/qemu-(img|io).*|/util/(aio|async|thread-pool).*)
>>> +  ~ .*/qemu(/block.*|(/include?)/(block|storage-daemon)/.*|(/include)?/hw/(block|ide|nvme)/.*|/qemu-(img|io).*|/util/(aio|async|thread-pool).*)
>>
>> util/block-helpers.[ch]
>>
>> I'd put hw/block/ to another bucket that the block subsystem.
> 
> MAINTAINERS considers both block/ and hw/block/ to be part of the
> "block layer core".

Personally I'd look at hw/block/ issues and skip block/ ones :P

>>>    disas
>>> -  ~ (/qemu)?((/include)?/disas.*)
>>> +  ~ .*/qemu((/include)?/disas.*)
>>
>> Missing:
>>
>> target/avr/disas.c
>> target/loongarch/disas.c
>> target/openrisc/disas.c
>> target/rx/disas.c
> 
> Why do these targets not put their disassembler in disas/
> like all the others? We can't really catch them with a
> wildcard, because the target entry earlier will match first.
> I'm kind of inclined to leave these as-is, because if
> somebody put the disassembler in target/ then having it
> appear in the component for that target is fine for it being
> basically classified to get the attention of the right person.

disas/ is for non-decodetree disassemblers imported from
BFD library. Decodetree based belong to each target/foo/.
So I agree keeping as-is is OK.

Regards,

Phil.


      reply	other threads:[~2024-06-04 15:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-31 14:21 [PATCH] scripts/coverity-scan/COMPONENTS.md: Update paths to match gitlab CI Peter Maydell
2024-05-31 15:17 ` Philippe Mathieu-Daudé
2024-06-04 13:32   ` Peter Maydell
2024-06-04 15:09     ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a935eea-fc4f-4b11-b981-8670f03615f0@linaro.org \
    --to=philmd@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).