qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: qemu-devel@nongnu.org
Cc: philmd@linaro.org, Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org, alex.bennee@linaro.org,
	Marcelo Tosatti <mtosatti@redhat.com>,
	"Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>,
	richard.henderson@linaro.org, manos.pitsidianakis@linaro.org
Subject: Re: [PATCH v4 0/7] hw/hyperv: remove duplication compilation units
Date: Thu, 20 Mar 2025 12:00:39 -0700	[thread overview]
Message-ID: <5a97e6c4-72aa-492b-8e7f-c0f874ffaf23@linaro.org> (raw)
In-Reply-To: <20250307215623.524987-1-pierrick.bouvier@linaro.org>

On 3/7/25 13:56, Pierrick Bouvier wrote:
> Work towards having a single binary, by removing duplicated object files.
> 
> hw/hyperv/hyperv.c was excluded at this time, because it depends on target
> dependent symbols:
> - from system/kvm.h
>      - kvm_check_extension
>      - kvm_vm_ioctl
> - from exec/cpu-all.h | memory_ldst_phys.h.inc
>      - ldq_phys
> 
> v2
> - remove osdep from header
> - use hardcoded buffer size for syndbg, assuming page size is always 4Kb.
> 
> v3
> - fix assert for page size.
> 
> v4
> - use KiB unit
> 
> Pierrick Bouvier (7):
>    hw/hyperv/hv-balloon-stub: common compilation unit
>    hw/hyperv/hyperv.h: header cleanup
>    hw/hyperv/vmbus: common compilation unit
>    hw/hyperv/hyperv-proto: move SYNDBG definition from target/i386
>    hw/hyperv/syndbg: common compilation unit
>    hw/hyperv/balloon: common balloon compilation units
>    hw/hyperv/hyperv_testdev: common compilation unit
> 
>   include/hw/hyperv/hyperv-proto.h | 12 ++++++++
>   include/hw/hyperv/hyperv.h       |  3 +-
>   target/i386/kvm/hyperv-proto.h   | 12 --------
>   hw/hyperv/syndbg.c               | 11 +++++--
>   hw/hyperv/vmbus.c                | 50 ++++++++++++++++----------------
>   hw/hyperv/meson.build            |  9 +++---
>   6 files changed, 52 insertions(+), 45 deletions(-)
> 

I've been able to address comments and conver last compilation unit 
missing (hw/hyperv/hyperv.c).

However, another series is needed to make this compile.
Thus, I'll wait for this to be merged before sending the v5 here.


      parent reply	other threads:[~2025-03-20 19:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 21:56 [PATCH v4 0/7] hw/hyperv: remove duplication compilation units Pierrick Bouvier
2025-03-07 21:56 ` [PATCH v4 1/7] hw/hyperv/hv-balloon-stub: common compilation unit Pierrick Bouvier
2025-03-07 21:56 ` [PATCH v4 2/7] hw/hyperv/hyperv.h: header cleanup Pierrick Bouvier
2025-03-11 15:05   ` Philippe Mathieu-Daudé
2025-03-11 15:14     ` Philippe Mathieu-Daudé
2025-03-07 21:56 ` [PATCH v4 3/7] hw/hyperv/vmbus: common compilation unit Pierrick Bouvier
2025-03-07 21:56 ` [PATCH v4 4/7] hw/hyperv/hyperv-proto: move SYNDBG definition from target/i386 Pierrick Bouvier
2025-03-07 21:56 ` [PATCH v4 5/7] hw/hyperv/syndbg: common compilation unit Pierrick Bouvier
2025-03-07 21:56 ` [PATCH v4 6/7] hw/hyperv/balloon: common balloon compilation units Pierrick Bouvier
2025-03-07 21:56 ` [PATCH v4 7/7] hw/hyperv/hyperv_testdev: common compilation unit Pierrick Bouvier
2025-03-07 22:06 ` [PATCH v4 0/7] hw/hyperv: remove duplication compilation units Philippe Mathieu-Daudé
2025-03-07 22:38   ` Pierrick Bouvier
2025-03-07 22:25 ` Philippe Mathieu-Daudé
2025-03-07 22:31   ` Maciej S. Szmigiero
2025-03-07 22:37     ` Philippe Mathieu-Daudé
2025-03-09 23:33     ` Pierrick Bouvier
2025-03-10  0:14       ` Philippe Mathieu-Daudé
2025-03-10  2:10         ` Pierrick Bouvier
2025-03-10 12:28         ` Maciej S. Szmigiero
2025-03-10 12:28       ` Maciej S. Szmigiero
2025-03-20 19:00 ` Pierrick Bouvier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a97e6c4-72aa-492b-8e7f-c0f874ffaf23@linaro.org \
    --to=pierrick.bouvier@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=kvm@vger.kernel.org \
    --cc=maciej.szmigiero@oracle.com \
    --cc=manos.pitsidianakis@linaro.org \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).