From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Richard W.M. Jones" <rjones@redhat.com>,
qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Cc: alxndr@bu.edu, pbonzini@redhat.com, bsd@redhat.com,
stefanha@redhat.com, thuth@redhat.com, darren.kenny@oracle.com,
Qiuhao.Li@outlook.com, fam@euphon.net, lvivier@redhat.com,
berrange@redhat.com
Subject: Re: [PATCH] tests: Ensure TAP version is printed before other messages
Date: Mon, 27 Feb 2023 23:01:43 +0100 [thread overview]
Message-ID: <5aa19e4c-9d91-3446-33d2-08bcf46c15ed@linaro.org> (raw)
In-Reply-To: <20230227174019.1164205-1-rjones@redhat.com>
On 27/2/23 18:40, Richard W.M. Jones wrote:
> These two tests were failing with this error:
>
> stderr:
> TAP parsing error: version number must be on the first line
> [...]
> Unknown TAP version. The first line MUST be `TAP version <int>`. Assuming version 12.
>
> This can be fixed by ensuring we always call g_test_init first in the
> body of main.
>
> Thanks: Daniel Berrange, for diagnosing the problem
> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> ---
> tests/qtest/fuzz-lsi53c895a-test.c | 4 ++--
> tests/qtest/rtl8139-test.c | 5 +++--
> 2 files changed, 5 insertions(+), 4 deletions(-)
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Thanks for tackling this!
next prev parent reply other threads:[~2023-02-27 22:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 17:40 [PATCH] tests: Ensure TAP version is printed before other messages Richard W.M. Jones
2023-02-27 17:44 ` Daniel P. Berrangé
2023-02-27 17:46 ` Darren Kenny
2023-02-27 19:57 ` Alexander Bulekov
2023-02-27 22:01 ` Philippe Mathieu-Daudé [this message]
2023-02-28 15:37 ` Alex Bennée
2023-02-28 20:30 ` Thomas Huth
2023-03-01 10:52 ` Richard W.M. Jones
2023-03-01 10:56 ` Thomas Huth
2023-03-01 11:00 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5aa19e4c-9d91-3446-33d2-08bcf46c15ed@linaro.org \
--to=philmd@linaro.org \
--cc=Qiuhao.Li@outlook.com \
--cc=alex.bennee@linaro.org \
--cc=alxndr@bu.edu \
--cc=berrange@redhat.com \
--cc=bsd@redhat.com \
--cc=darren.kenny@oracle.com \
--cc=fam@euphon.net \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).