From: Paolo Bonzini <pbonzini@redhat.com>
To: Colin Lord <clord@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, markmb@redhat.com, qemu-block@nongnu.org,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] blockdev: Add dynamic module loading for block drivers
Date: Thu, 16 Jun 2016 16:05:48 +0200 [thread overview]
Message-ID: <5ab1035f-c3b4-1974-cb2d-db5c46ab9c56@redhat.com> (raw)
In-Reply-To: <3363671b-2488-8a82-ea3c-82e24c9a031e@redhat.com>
On 16/06/2016 16:00, Colin Lord wrote:
>> >> The only block drivers that can be converted into modules are the drivers
>> >> that don't perform any init operation except for registering themselves. This
>> >> is why libiscsi has been disabled as a module.
> >
> > I don't think it has in this patch :) but you can also move the
> > iscsi_opts registration to vl.c.
>
> Yeah I think Stefan mentioned this point in one of the earlier threads
> but he said to do it in a separate commit, which I took to mean I
> shouldn't include it here. Should I add it as a third part to this patch
> series or leave it for a completely separate commit?
The patches in the series are left separate when including them in QEMU.
Therefore, a separate patch *is* (or will become :)) a separate commit.
Therefore, putting the change before this patch, or alternatively as the
first patch in the series, will be fine.
Thanks,
Paolo
next prev parent reply other threads:[~2016-06-16 14:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 18:40 [Qemu-devel] [PATCH 0/2] Dynamic module loading for block drivers Colin Lord
2016-06-15 18:40 ` [Qemu-devel] [PATCH 1/2] blockdev: Add dynamic generation of module_block.h Colin Lord
2016-06-15 22:48 ` Paolo Bonzini
2016-06-16 4:59 ` Fam Zheng
2016-06-16 13:57 ` Colin Lord
2016-06-17 9:57 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-06-15 18:40 ` [Qemu-devel] [PATCH 2/2] blockdev: Add dynamic module loading for block drivers Colin Lord
2016-06-15 22:50 ` Paolo Bonzini
2016-06-16 14:00 ` Colin Lord
2016-06-16 14:05 ` Paolo Bonzini [this message]
2016-06-16 14:10 ` Colin Lord
2016-06-16 14:12 ` Paolo Bonzini
2016-06-17 9:54 ` [Qemu-devel] [Qemu-block] [PATCH 0/2] Dynamic " Stefan Hajnoczi
2016-06-20 15:32 ` Colin Lord
2016-06-21 9:32 ` Stefan Hajnoczi
2016-06-21 10:01 ` [Qemu-devel] " Paolo Bonzini
2016-06-21 15:42 ` [Qemu-devel] [Qemu-block] " Colin Lord
2016-06-21 16:59 ` [Qemu-devel] " Paolo Bonzini
2016-06-22 10:09 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ab1035f-c3b4-1974-cb2d-db5c46ab9c56@redhat.com \
--to=pbonzini@redhat.com \
--cc=clord@redhat.com \
--cc=kwolf@redhat.com \
--cc=markmb@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).