* [PATCH] tests: tcg: Fix PVH test with binutils 2.36+
@ 2021-10-08 16:21 Cole Robinson
2021-10-08 17:14 ` Paolo Bonzini
2021-10-10 12:21 ` Alex Bennée
0 siblings, 2 replies; 3+ messages in thread
From: Cole Robinson @ 2021-10-08 16:21 UTC (permalink / raw)
To: qemu-devel
Cc: alex.bennee, Paolo Bonzini, richard.henderson, ehabkost,
Cole Robinson
binutils started adding a .note.gnu.property ELF section which
makes the PVH test fail:
TEST hello on x86_64
qemu-system-x86_64: Error loading uncompressed kernel without PVH ELF Note
Discard .note.gnu* while keeping the PVH .note bits intact.
This also strips the build-id note, so drop the related comment.
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
tests/tcg/x86_64/system/kernel.ld | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/tcg/x86_64/system/kernel.ld b/tests/tcg/x86_64/system/kernel.ld
index 49c12b04ae..ca5d6bd850 100644
--- a/tests/tcg/x86_64/system/kernel.ld
+++ b/tests/tcg/x86_64/system/kernel.ld
@@ -16,7 +16,10 @@ SECTIONS {
*(.rodata)
} :text
- /* Keep build ID and PVH notes in same section */
+ /DISCARD/ : {
+ *(.note.gnu*)
+ }
+
.notes : {
*(.note.*)
} :note
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] tests: tcg: Fix PVH test with binutils 2.36+
2021-10-08 16:21 [PATCH] tests: tcg: Fix PVH test with binutils 2.36+ Cole Robinson
@ 2021-10-08 17:14 ` Paolo Bonzini
2021-10-10 12:21 ` Alex Bennée
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2021-10-08 17:14 UTC (permalink / raw)
To: Cole Robinson, qemu-devel; +Cc: alex.bennee, richard.henderson, ehabkost
On 08/10/21 18:21, Cole Robinson wrote:
> binutils started adding a .note.gnu.property ELF section which
> makes the PVH test fail:
>
> TEST hello on x86_64
> qemu-system-x86_64: Error loading uncompressed kernel without PVH ELF Note
>
> Discard .note.gnu* while keeping the PVH .note bits intact.
>
> This also strips the build-id note, so drop the related comment.
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
> tests/tcg/x86_64/system/kernel.ld | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/tcg/x86_64/system/kernel.ld b/tests/tcg/x86_64/system/kernel.ld
> index 49c12b04ae..ca5d6bd850 100644
> --- a/tests/tcg/x86_64/system/kernel.ld
> +++ b/tests/tcg/x86_64/system/kernel.ld
> @@ -16,7 +16,10 @@ SECTIONS {
> *(.rodata)
> } :text
>
> - /* Keep build ID and PVH notes in same section */
> + /DISCARD/ : {
> + *(.note.gnu*)
> + }
> +
> .notes : {
> *(.note.*)
> } :note
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tests: tcg: Fix PVH test with binutils 2.36+
2021-10-08 16:21 [PATCH] tests: tcg: Fix PVH test with binutils 2.36+ Cole Robinson
2021-10-08 17:14 ` Paolo Bonzini
@ 2021-10-10 12:21 ` Alex Bennée
1 sibling, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2021-10-10 12:21 UTC (permalink / raw)
To: Cole Robinson; +Cc: Paolo Bonzini, richard.henderson, qemu-devel, ehabkost
Cole Robinson <crobinso@redhat.com> writes:
> binutils started adding a .note.gnu.property ELF section which
> makes the PVH test fail:
>
> TEST hello on x86_64
> qemu-system-x86_64: Error loading uncompressed kernel without PVH ELF Note
>
> Discard .note.gnu* while keeping the PVH .note bits intact.
>
> This also strips the build-id note, so drop the related comment.
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
Acked-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-10 12:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-08 16:21 [PATCH] tests: tcg: Fix PVH test with binutils 2.36+ Cole Robinson
2021-10-08 17:14 ` Paolo Bonzini
2021-10-10 12:21 ` Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).