From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: konrad@adacore.com, alex.bennee@linaro.org
Cc: frederic.konrad@adacore.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] semihosting: remove the pthread include which seems unused
Date: Mon, 18 May 2020 15:50:39 +0200 [thread overview]
Message-ID: <5ab6f370-6725-1cdb-1b82-24a58cb7642e@redhat.com> (raw)
In-Reply-To: <1589806958-23511-1-git-send-email-frederic.konrad@adacore.com>
On 5/18/20 3:02 PM, konrad@adacore.com wrote:
> From: KONRAD Frederic <frederic.konrad@adacore.com>
>
> This have been introduced by:
> 8de702cb677c8381fb702cae252d6b69aa4c653b
>
> It doesn't seem to be used so remove it.
>
> Signed-off-by: KONRAD Frederic <frederic.konrad@adacore.com>
> ---
> hw/semihosting/console.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c
> index 6346bd7..22e7827 100644
> --- a/hw/semihosting/console.c
> +++ b/hw/semihosting/console.c
> @@ -23,7 +23,6 @@
> #include "exec/exec-all.h"
> #include "qemu/log.h"
> #include "chardev/char.h"
> -#include <pthread.h>
> #include "chardev/char-fe.h"
> #include "sysemu/sysemu.h"
> #include "qemu/main-loop.h"
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-05-18 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 13:02 [PATCH] semihosting: remove the pthread include which seems unused konrad
2020-05-18 13:50 ` Philippe Mathieu-Daudé [this message]
2020-06-01 9:19 ` Fred Konrad
2020-06-01 10:29 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ab6f370-6725-1cdb-1b82-24a58cb7642e@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=frederic.konrad@adacore.com \
--cc=konrad@adacore.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).