qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
	Sergio Andres Gomez Del Real <sergio.g.delreal@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-options: Add missing newline to -accel help text
Date: Thu, 21 Jun 2018 12:01:57 +0200	[thread overview]
Message-ID: <5abab447-b25b-0431-5fc9-7b6cda73e7a5@redhat.com> (raw)
In-Reply-To: <20180611195607.3015-1-ehabkost@redhat.com>

On 11/06/2018 21:56, Eduardo Habkost wrote:
> The newline was removed by commit c97d6d2c, and broke -help output:
> 
> Before this patch:
> 
>   $ qemu-system-x86_64 -help | grep smp
>                   thread=single|multi (enable multi-threaded TCG)-smp [...]
> 
> After this patch:
> 
>   $ qemu-system-x86_64 -help  | grep smp
>   -smp [cpus=]n[,maxcpus=cpus][,cores=cores][,threads=threads][,sockets=sockets]
> 
> Fixes: c97d6d2cdf97edb4aebe832fdba65d701ad7bcb6
> Cc: Sergio Andres Gomez Del Real <sergio.g.delreal@gmail.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index c0d3951e9f..6364cf3f94 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -130,7 +130,7 @@ ETEXI
>  DEF("accel", HAS_ARG, QEMU_OPTION_accel,
>      "-accel [accel=]accelerator[,thread=single|multi]\n"
>      "                select accelerator (kvm, xen, hax, hvf, whpx or tcg; use 'help' for a list)\n"
> -    "                thread=single|multi (enable multi-threaded TCG)", QEMU_ARCH_ALL)
> +    "                thread=single|multi (enable multi-threaded TCG)\n", QEMU_ARCH_ALL)
>  STEXI
>  @item -accel @var{name}[,prop=@var{value}[,...]]
>  @findex -accel
> 

Queued, thanks.

Paolo

      parent reply	other threads:[~2018-06-21 10:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11 19:56 [Qemu-devel] [PATCH] qemu-options: Add missing newline to -accel help text Eduardo Habkost
2018-06-11 20:05 ` Eric Blake
2018-06-21 10:01 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5abab447-b25b-0431-5fc9-7b6cda73e7a5@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sergio.g.delreal@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).