From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdeOn-0000nM-Rv for qemu-devel@nongnu.org; Thu, 12 Jul 2018 12:24:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdeOn-0008Ae-0t for qemu-devel@nongnu.org; Thu, 12 Jul 2018 12:24:57 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59198 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fdeOm-0008AP-Rg for qemu-devel@nongnu.org; Thu, 12 Jul 2018 12:24:56 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 748A74022909 for ; Thu, 12 Jul 2018 16:24:56 +0000 (UTC) References: <20180712111221.20326-1-armbru@redhat.com> <20180712111221.20326-4-armbru@redhat.com> From: Thomas Huth Message-ID: <5ac2b9b4-3940-eba7-e0f9-9f3f59f6c871@redhat.com> Date: Thu, 12 Jul 2018 18:24:54 +0200 MIME-Version: 1.0 In-Reply-To: <20180712111221.20326-4-armbru@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/20] libqtest: Clean up how we read device_del messages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org On 12.07.2018 13:12, Markus Armbruster wrote: > qtest_qmp_device_del() still uses the qmp("") hack to receive a > message, even though we have qmp_receive() since commit 66e0c7b187e. > Put it to use. > > Bonus: gets rid of empty format strings. A step towards compile-time > format string checking without triggering -Wformat-zero-length. > > Signed-off-by: Markus Armbruster > --- > tests/libqtest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/libqtest.c b/tests/libqtest.c > index 9cb4096639..071d7eb7b1 100644 > --- a/tests/libqtest.c > +++ b/tests/libqtest.c > @@ -1090,7 +1090,7 @@ void qtest_qmp_device_del(const char *id) > g_assert(response1); > g_assert(!qdict_haskey(response1, "error")); > > - response2 = qmp(""); > + response2 = qmp_receive(); > g_assert(response2); > g_assert(!qdict_haskey(response2, "error")); Reviewed-by: Thomas Huth