qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: "open list:S390 TCG CPUs" <qemu-s390x@nongnu.org>,
	Cornelia Huck <cohuck@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	David Hildenbrand <david@redhat.com>
Subject: Re: [RFC PATCH] tests/tcg: drop -cpu max from s390x sha512-mvx invocation
Date: Thu, 10 Mar 2022 09:36:53 +0100	[thread overview]
Message-ID: <5ac2ce87-90a3-05f9-d65e-a8ef9854863c@redhat.com> (raw)
In-Reply-To: <20220309112248.4083619-1-alex.bennee@linaro.org>

On 09/03/2022 12.22, Alex Bennée wrote:
> With -cpu max we get a warning:
> 
>    qemu-s390x: warning: 'msa5-base' requires 'kimd-sha-512'.
> 
> But dropping the -cpu max and it still runs fine.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Thomas Huth <thuth@redhat.com>
> ---
>   tests/tcg/s390x/Makefile.target | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/tests/tcg/s390x/Makefile.target b/tests/tcg/s390x/Makefile.target
> index 257c568c58..7aa502a557 100644
> --- a/tests/tcg/s390x/Makefile.target
> +++ b/tests/tcg/s390x/Makefile.target
> @@ -34,6 +34,4 @@ sha512-mvx: CFLAGS=-march=z13 -mvx -O3
>   sha512-mvx: sha512.c
>   	$(CC) $(CFLAGS) $(EXTRA_CFLAGS) $< -o $@ $(LDFLAGS)
>   
> -run-sha512-mvx: QEMU_OPTS+=-cpu max
> -
>   TESTS+=sha512-mvx

Ok, this helps to get rid of the warnings, thus feel free to add:

Tested-by: Thomas Huth <thuth@redhat.com>

However, the error still persists. I now had a closer look by running the 
test with "qemu-s390x" on my z15 machine directly, and all tests are 
failing! The problem happens with both, gcc v11.2.1 and clang v13.0.1. The 
problem goes away (i.e. test works fine) if I compile the code with -O1 
instead of -O3, or if I use GCC v8.5 instead. I'll try to find out more, but 
as a temporary workaround, we could also switch to -O1 instead of -O3.

  Thomas



  parent reply	other threads:[~2022-03-10  8:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-09 11:22 [RFC PATCH] tests/tcg: drop -cpu max from s390x sha512-mvx invocation Alex Bennée
2022-03-09 11:23 ` David Hildenbrand
2022-03-09 20:44 ` Richard Henderson
2022-03-10  8:36 ` Thomas Huth [this message]
2022-03-10 10:21   ` Thomas Huth
2022-03-10 11:35     ` Richard Henderson
2022-03-10 12:28       ` Thomas Huth
2022-03-10 10:34   ` Alex Bennée
2022-03-10 10:41     ` Thomas Huth
2022-03-10 11:33       ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ac2ce87-90a3-05f9-d65e-a8ef9854863c@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).