From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A90F0C64ED6 for ; Mon, 27 Feb 2023 09:20:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWZgW-0002h1-PU; Mon, 27 Feb 2023 04:20:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWZgJ-0002bn-IX for qemu-devel@nongnu.org; Mon, 27 Feb 2023 04:20:32 -0500 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pWZgH-0004mM-Ld for qemu-devel@nongnu.org; Mon, 27 Feb 2023 04:20:26 -0500 Received: by mail-pj1-x1036.google.com with SMTP id x34so5469574pjj.0 for ; Mon, 27 Feb 2023 01:20:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uwSuFKJnAnL7OPyfUA15m3jwukwHz8iMscS2BHfI2EE=; b=N7lfDI+ql40hE3RbnbV23mwLy1xLQtIWy9WVK289T4RdQ9ghAEzQ6Sz2q2Bo+fumDR 5mBfbnFqTZq6O+SnRHUDVuI0uOuArw7bf7mj9pNdqBikozy5B98zXhDKzbBBUrNiHg/A BUM4owTN3o7TdJA+z8LW3gr61Puqx7GlmPLFZR4Qcn9vYgapz+skvdGjHA8smgcZuKSo CATut4UkQfK7Halh7XYj4qmO06JYNlF/n3PFvZiz+FzAA9nLa/askNTpRv/zMRGbBc6s si/yeParMzs/G3v4ird0k2+EFTpIV3zC+xwFcRnQhkmVp2t6yd4sj/l1aLIaxux64oRL HKxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uwSuFKJnAnL7OPyfUA15m3jwukwHz8iMscS2BHfI2EE=; b=rRvI1hJzr9LR9FpIQwrXLnvR6BeChvUDEGXaFoFK/uqQIffpK8KytwxfL2MVZR5sKG Z5oo/Fpr1HJV3uMoPzDVUY2pFgMaTNBcA6y1KAky53zW9Fvi3pZo/LHf9zIBTV8obxJq wgHZ/GaqWtwPEA2QR0cLdmZtLmfBmUzANoK4DgHffgmpR/z0JCbF5wlzV8iEohAxhK2P K82z+LyUvumWatoZ8QH6QnTSnJBPHmZEn1hWWe1+5J7j/RigKrRvoL7Y7f4hf671qUu1 Ufei+iYJqYet0lfzMSCmmKc0lf7lQPMT/i45jOnHFnZi2d0kf2bAEYKN+Ir/jBMKvg+o QLLQ== X-Gm-Message-State: AO0yUKVj1AOVS4ZQdcPxrX5X2IDO3a6JHudkeg5z4GElmGj4COS76ltW Rion3h4UYn2FoxcYo7dbo22Apw== X-Google-Smtp-Source: AK7set9LtMcv6Dobf6nbcmHoquKZnozt8QJkqP0blLRreY+jur0dCK34FRB9fJ04ZCBT+DgTTC8sYQ== X-Received: by 2002:a05:6a20:3956:b0:bc:5a6:1b2a with SMTP id r22-20020a056a20395600b000bc05a61b2amr28425844pzg.49.1677489623819; Mon, 27 Feb 2023 01:20:23 -0800 (PST) Received: from [192.168.6.128] (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id d7-20020aa78147000000b005ac419804d3sm3767243pfn.186.2023.02.27.01.20.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 01:20:23 -0800 (PST) Message-ID: <5ac3c25f-8d4b-6aa3-5bc2-2b3abc22dce8@linaro.org> Date: Sun, 26 Feb 2023 23:20:20 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [RFC PATCH 10/43] target/loongarch: Implement vaddw/vsubw Content-Language: en-US To: gaosong , qemu-devel@nongnu.org References: <20221224081633.4185445-1-gaosong@loongson.cn> <20221224081633.4185445-11-gaosong@loongson.cn> <268ef762-fce5-ca47-d5f7-bd60955a3a0f@linaro.org> <1ad204fc-8f7e-0f1c-e8f6-163d11f3880b@linaro.org> From: Richard Henderson In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1036; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1036.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/26/23 23:14, gaosong wrote: > like this: > the vece is MO_32. > static void gen_vaddwev_s(unsigned vece, TCGv_vec t, TCGv_vec a, TCGv_vec b) > { >     TCGv_vec t1 = tcg_temp_new_vec_matching(a); >     TCGv_vec t2 = tcg_temp_new_vec_matching(b); >     int halfbits = 4 << vece; >     tcg_gen_shli_vec(vece, t1, a, halfbits); >     tcg_gen_shri_vec(vece, t1, t1, halfbits); > >     tcg_gen_shli_vec(vece, t2, b,  halfbits); >     tcg_gen_shri_vec(vece, t2, t2, halfbits); > >     tcg_gen_add_vec(vece, t, t1, t2); > >     tcg_temp_free_vec(t1); >     tcg_temp_free_vec(t2); > } > ... >        op[MO_16]; >         { >             .fniv = gen_vaddwev_s, >             .fno = gen_helper_vaddwev_w_h, >             .opt_opc = vecop_list, >             .vece = MO_32 >         }, > ... > TRANS(vaddwev_w_h, gvec_vvv, MO_16, gvec_vaddwev_s) > > input :     0x ffff fffe ffff fffe  ffff fffe ffff fffe  + 0 > output :    0x 0000 fffe 0000 fffe  0000 fffe 0000 fffe > correct is  0xffffffffefffffffefffffffe ffff fffe. sari above, not shri, for sign-extension. r~